Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fullstory] add version and appId to reports #111952

Merged
merged 7 commits into from
Sep 15, 2021

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Sep 13, 2021

Summary

Add the following user vars to all Fullstory events

  • version
  • major
  • minor
  • patch
  • currentAppId

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@lizozom lizozom requested a review from lukeelmers September 13, 2021 13:31
@lizozom lizozom requested a review from a team as a code owner September 13, 2021 13:31
@lizozom lizozom self-assigned this Sep 13, 2021
@lizozom lizozom added v7.14.2 v7.15.1 v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Sep 13, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

x-pack/plugins/cloud/public/plugin.ts Outdated Show resolved Hide resolved
x-pack/plugins/cloud/public/plugin.ts Outdated Show resolved Hide resolved
x-pack/plugins/cloud/public/plugin.ts Outdated Show resolved Hide resolved
x-pack/plugins/cloud/public/plugin.ts Outdated Show resolved Hide resolved
x-pack/plugins/cloud/public/plugin.ts Outdated Show resolved Hide resolved
x-pack/plugins/cloud/public/plugin.ts Outdated Show resolved Hide resolved
x-pack/plugins/cloud/public/fullstory.ts Outdated Show resolved Hide resolved
@lizozom
Copy link
Contributor Author

lizozom commented Sep 14, 2021

@pgayvallet @lukeelmers fixed all of your comments.
Would love to get this reviewed so I can backport to the 7.14.2 version which FF is today :-)

Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when comments are addressed

x-pack/plugins/cloud/public/plugin.ts Outdated Show resolved Hide resolved
x-pack/plugins/cloud/public/plugin.ts Outdated Show resolved Hide resolved
x-pack/plugins/cloud/public/plugin.ts Outdated Show resolved Hide resolved
@lizozom lizozom added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 14, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloud 9.4KB 10.5KB +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lizozom

@lizozom lizozom merged commit 7195317 into elastic:master Sep 15, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 15, 2021
* add version and appId to reports

* tests

* code review

* cr 2

* manual parsing + todo
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 15, 2021
* add version and appId to reports

* tests

* code review

* cr 2

* manual parsing + todo
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 15, 2021
* add version and appId to reports

* tests

* code review

* cr 2

* manual parsing + todo
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x
7.14
7.15

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 15, 2021
* add version and appId to reports

* tests

* code review

* cr 2

* manual parsing + todo

Co-authored-by: Liza Katz <[email protected]>
kibanamachine added a commit that referenced this pull request Sep 15, 2021
* add version and appId to reports

* tests

* code review

* cr 2

* manual parsing + todo

Co-authored-by: Liza Katz <[email protected]>
kibanamachine added a commit that referenced this pull request Sep 15, 2021
* add version and appId to reports

* tests

* code review

* cr 2

* manual parsing + todo

Co-authored-by: Liza Katz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.2 v7.15.0 v7.15.1 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants