Upgrade set-value to 4.1.0 #111988
Merged
Upgrade set-value to 4.1.0 #111988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
added
chore
v8.0.0
release_note:skip
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
|
@elastic/kibana-vis-editors I pinged you for review because this dependency is primarily used by TSVB. I'd appreciate a quick manual test to make sure I haven't introduced a regression here. Thanks! |
stratoula
approved these changes
Sep 14, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 14, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 14, 2021
kibanamachine
added a commit
that referenced
this pull request
Sep 14, 2021
Co-authored-by: Larry Gregory <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 14, 2021
Co-authored-by: Larry Gregory <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
set-valueto4.1.0(was:3.0.2).The changelog for this dependency is quite lacking. Based on the diff, I suspect that the reason for the major version bump was dropping support for Node.js 10 (jonschlinkert/set-value@599bccc), which prevents us from backporting this to 6.x.