Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13133] Test automation #14

Closed
wants to merge 48 commits into from
Closed

[#13133] Test automation #14

wants to merge 48 commits into from

Conversation

domoberzin
Copy link
Owner

Fixes #

Outline of Solution

marquestye and others added 30 commits April 19, 2024 15:37
@marquestye @FergusMok
Add composite index for data migration (TEAMMATES#13057)
498efdc 
Co-authored-by: FergusMok <[email protected]>
@ziqing26
[TEAMMATES#13060] Add beta 5 liquibase changelog and developers json (T…
81eae17 
…EAMMATES#13061)

* Add beta 5 changelog

* Update changelog to be in alphabetical order

* Update developers.json
@NicolasCwy
[TEAMMATES#12048] Update changelog docs and changelog name (TEAMMATES…
0a0e7c9 
…#13062)

* Update docs

* Rename changelog file

* Amend changelog naming
@cedricongjh @weiquu
[TEAMMATES#12048] Migrate StudentCourseDetailsPageE2ETest (TEAMMATES#…
10e96cb 
…13012)

* Migrate StudentCourseDetailsPageE2ETest

* Add StudentCourseDetailsPageE2ETest to sql xml

---------

Co-authored-by: Wei Qing <[email protected]>
@domoberzin
[TEAMMATES#11878] Account Request Indexing Script (TEAMMATES#13076)
76db4cc 
* add script

* order commit

* update logic

* convert to batch

* remove print
@xenosf @jayasting98
[TEAMMATES#11878] Add CAPTCHA to ARF (TEAMMATES#13081)
6b83e4f 
* Add captcha to ARF

* Update front-end tests

* Fix lint errors

* Change captcha to uppercase in error text

* Return captcha response when the getter is called

---------

Co-authored-by: Jay Aljelo Ting <[email protected]>
@Stain19 @cedricongjh
[TEAMMATES#13064] Use AccountRequestUpdateRequest as parameter (TEAM…
e738e25 
…MATES#13068)

* Update editAccountRequest parameter type to AccountRequestUpdateRequest

* Fixing the lint

* Refatoring editAccountRequest method

---------

Co-authored-by: Cedric Ong <[email protected]>
@yuanxi1 @weiquu
[TEAMMATES#12048] Migrate FeedbackRubricQuestionsE2E (TEAMMATES#13078)
a2a9ef3 
* Add e2e test

* Migrate all tests

* Update xml

---------

Co-authored-by: YX Z <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
@FergusMok
[TEAMMATES#12048] Migrate SubmitFeedbackResponseAction tests (TEAMMAT…
34248a0 
…ES#13033)

* Skeleton till shouldAllowIfBeforeDeadline

* Save progress

* Save progress

* Fix all tests

* Fix linting

* Remove redundant

* Refactor to fit integration tests structure

* Add breaking changes

* Add flush

* Fix linting

* Fix clean-up from access control
@emrekenar
[TEAMMATES#12900] Gradle task componentTests should not stop entirely…
1ea04f4 
… when only one task fails (TEAMMATES#12963)
@FergusMok @NicolasCwy @wkurniawan07
[TEAMMATES#12048] Remove null default section (TEAMMATES#13040)
06bfafd 
* Add changes

* Add missing

---------

Co-authored-by: Nicolas <[email protected]>
Co-authored-by: Wilson Kurniawan <[email protected]>
@dishenggg
[TEAMMATES#13126] Fix failing component test cases (TEAMMATES#13127)
7b75dad 
* Fix failing test cases

* Update test logs with unique sorting order

* Revert AccountRequestDbIT
@wkurniawan07
[TEAMMATES#13126] Update timezone db (TEAMMATES#13128)
5ed1cf7
@Ashwinn11 @domoberzin
[TEAMMATES#13109] IndexOutOfBoundsException encountered by LogsProces…
ec1f276 
…sor (TEAMMATES#13120)

* TEAMMATES#13109-added check to see if logs is empty

* switch back to logs.get(list.size()-1)

* [TEAMMATES#13109] IndexOutOfBoundsException encountered by LogsProcessor

---------

Co-authored-by: domoberzin <[email protected]>
@Ashwinn11
[TEAMMATES#13103] Account request form: No need to CC the email 'Ackn…
6114677 
…owledgement of Instructor Account Request' (TEAMMATES#13116)
@Respirayson
Remove duplicate call to loadfeedbacksessionsforcourse (TEAMMATES#13130)
40350ef
@Andy-W-Developer @domoberzin @weiquu
[TEAMMATES#13102] Admin rejecting account request: give actual accoun…
efeffd4 
…t in the email template (TEAMMATES#13118)

* Change existingEmail to googleId

* Add extra info to instructions

* Fix missing googleId if multiple accounts exist

* Add function name to test name

* Move account search to function

* Change missing googleId string to be shorter

* Add check for accounts with no googleId

* Add tests for replaceGoogleId

* Change instructor search result to use createBuilder

* Change a test name to fit convention

---------

Co-authored-by: domoberzin <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
@cliu585 @azhang49
@dishenggg @weiquu
[TEAMMATES#12901] Check if the search service is active in account re…
015b872 
…quest search test (TEAMMATES#13101)

* added check for active search service in account request search test

* moved account request search test to AccountRequestSearchIT and updated variables and asserts accordingly

* Add caution note to instructor email copies and remove hyperlinks

* updated account request test constructor to be consistent with latest commits

* fixed style errors

* fixed compiler errors

* fixed assertion error and style

* fixed linter errors

* Revert "Add caution note to instructor email copies and remove hyperlinks"

This reverts commit 232c757.

---------

Co-authored-by: Carolyn Liu <[email protected]>
Co-authored-by: Anna Zhang <[email protected]>
Co-authored-by: DS <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
@Respirayson
[TEAMMATES#13105] Admin managing account requests: use spinners to in…
b402863 
…dicate actions in progress (TEAMMATES#13135)

* Add spinners for approve, reject and reset in account-request-table

* Add spinners to regenerate keys in admin-search-page

* Update spinners in account-request-table to work individually

* Update tests

* Update buttons to be disabled while loading
@itstrueitstrueitsrealitsreal
[TEAMMATES#12872] Warn instructors not to share link with students (T…
f604c11 
…EAMMATES#13137)

* Add caution to template and change tests

* Update tests

* Fix failing test

* Change phrasing

* Fix typo

* Modify email template and tests

* Fix typo
@Respirayson @domoberzin
[TEAMMATES#12578] @ sign is shown as &TEAMMATES#64; when viewing …
836f637 
…essay question submission page (TEAMMATES#13142)

* Add decoding html entity functionality

* Add unit tests

---------

Co-authored-by: domoberzin <[email protected]>
@marquestye @mingyuanc
[TEAMMATES#12779] Fix notifications update logic (TEAMMATES#13083)
399a5fa 
* Fix notifications update logic

* Add required mocks

---------

Co-authored-by: Ching Ming Yuan <[email protected]>
@itstrueitstrueitsrealitsreal @domoberzin
[TEAMMATES#12894] Calculate msq totals by student email instead of na…
c5af284 
…me (TEAMMATES#13141)

* Calculate totals by email

* Standardize mcq and msq

* Undo sortBy

* Refactor initialization of variables

---------

Co-authored-by: domoberzin <[email protected]>
@weiquu @mingyuanc @domoberzin
[TEAMMATES#12048] Migrate InstructorCourseStudentDetailsEditPageE2ETe…
13a1891 
…st (TEAMMATES#13069)

* migrate

* get name from section and team

* update team

* fix data issues

---------

Co-authored-by: Ching Ming Yuan <[email protected]>
Co-authored-by: domoberzin <[email protected]>
@franciscoSavala @franciscoSavalaML
@weiquu @mingyuanc @domoberzin
[TEAMMATES#13104] Accounts request form: auto-unify country names (TE…
3f5f68d 
…AMMATES#13117)

* Added unified countries for InstructorRequestForm

* Added tests for InstructorRequestForm for unified countries

* Fixed lint errors for InstructorRequestForm

* Added countries and moved countrymapping

* Tests Fixed

---------

Co-authored-by: Francisco Savala <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: Ching Ming Yuan <[email protected]>
Co-authored-by: domoberzin <[email protected]>
@Respirayson
[TEAMMATES#12655] Instructor Edit Session Page: If make session visib…
61df45a 
…le is later than submission opening time, automatically default to opening time (TEAMMATES#13143)

* Update functionality to ensure session visibility time defaults to submission opening time

* Add unit tests

* Fix linting
@Respirayson
[TEAMMATES#12749] Autosave and restore progress if user navigates away (
67628fb 
TEAMMATES#13140)
@justinsegawa @weiquu @domoberzin
[TEAMMATES#12588] Test coverage improvements for InstructorResponsesV…
6b7912c 
…iewBase (TEAMMATES#13087)

* test coverage improvements for InstructorResponsesViewBase

* Lint fixes

* Update per-question-view-responses.component.spec.ts

* Fix for component tests

---------

Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: domoberzin <[email protected]>
@Respirayson
[TEAMMATES#13147] Didn't Account for the Timezone in Session Edit For…
9181467 
…m component tests (TEAMMATES#13148)
@itstrueitstrueitsrealitsreal
Add check for closed issue
05f0e5e
@github-actions GitHub Actions
Copy link

Hi @domoberzin, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@domoberzin domoberzin closed this Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.