[#12894] Calculate msq totals by student email instead of name #13141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dishenggg
reviewed
Jul 9, 2024
...s/question-statistics/question-statistics-calculation/msq-question-statistics-calculation.ts
Outdated
Show resolved
Hide resolved
dishenggg
reviewed
Jul 9, 2024
...s/question-statistics/question-statistics-calculation/msq-question-statistics-calculation.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12894
Outline of Solution
Following the discussion in #12894, I modified
msq-question-statistics.component.tsto take recipient emails into account.I also updated the code in
msq-question-statistics.component.tsto be more in line with the code inmcq-question-statistics.component.ts, callingtoFixed(2)to format the values in the table.In addition, I changed the tests to reflect the change from indexing students by name to indexing them by email.
I'd like to credit the authors of #12981, as I used their work to formulate my solution.