Per-recipient stats are calculated based on student name, not email

[damithc]

Reported by a user. V8.30

Example question:

Problem:
Per-recipient stats are calculated based on student name. When there are multiple students with the same name, their scores are added up. It should be based on student email instead, which is the only field guaranteed to be unique.

A similar problem might be affecting other places too, but this is the one reported by the user. As a temporary workaround, I've asked the used to disambiguate names so that no students have the same name.

[jckras]

Hi, can I work on this?

[cedricongjh]

hello @jckras feel free to submit a PR!

[jckras]

Reported by a user. V8.30

Example question:

Problem: Per-recipient stats are calculated based on student name. When there are multiple students with the same name, their scores are added up. It should be based on student email instead, which is the only field guaranteed to be unique.

A similar problem might be affecting other places too, but this is the one reported by the user. As a temporary workaround, I've asked the used to disambiguate names so that no students have the same name.

Hi @damithc the image that was included with this example does not seem to be a visualization of the problem occurring. Can you please provide clearer details on how to reproduce this issue? Thank you.

[damithc]

@jckras steps required to reproduce the problem:

1. Create a course that has multiple students with the same name
2. Simulate a session that has a question such as the one given in the screenshot
3. View the results (as an instructor) of that session and examine per-recipient stats of students with the same name

[jckras]

@damithc Thank you!

[jckras]

H @damithc, my partner @Hkovin and I have been working on this issue. We looked at somewhat similar issues for guidance such as https://github.com/TEAMMATES/teammates/issues/12125 We suspect that the issue may be coming from how the perRecipientResponses is being implemented in msq-question-statistics-calculation.ts We are looking here because this is what is used to implement the mcq-msq-question-statistics-calculation.ts (Multiple choice, multiple select question stat calculations). What are your thoughts on this?

[damithc]

@jckras Thanks for taking an interest in this issue.

What are your thoughts on this?

We can wait to see if other devs have some idea about this specific issue, but normally, it the the PR author's job to find the problem and propose a solution. So, try to come up with a solution that works, and the dev team members can give feedback on your solution.

[jckras]

@damithc Hi, I have a proposed solution for this bug! In the msq-question-statistics.component.ts file the perRecipientColumnsData object has the header descriptions shown below.

In order to separate responses based on student email, I think I should add another component of the perRecipientColumnsData object that includes the recipient email. After this change, the perRecipientColumnsData object implementation would look like the updated code shown below.

[cedricongjh]

hi @jckras, do submit a PR to let us do a code review, thank you!

[jckras]

Hi @damithc and @cedricongjh - found the issue, doing testing and submitting a PR this week. Wanted to follow up. Thank you!