Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12894] Calculate msq totals by student email instead of name #4

Closed
wants to merge 2 commits into from

Conversation

itstrueitstrueitsrealitsreal
Copy link
Owner

@itstrueitstrueitsrealitsreal itstrueitstrueitsrealitsreal commented Jul 1, 2024

Fixes TEAMMATES#12894

Outline of Solution
Following the discussion in TEAMMATES#12894, I modified both mcq-question-statistics.component.ts and msq-question-statistics.component.ts to take recipient emails into account.

I also updated the code in msq-question-statistics.component.ts to be more in line with the code in mcq-question-statistics.component.ts, calling toFixed(2) to format the values in the table.

In addition, I changed the tests to reflect the change from indexing students by name to indexing them by email.

I'd like to credit the authors of TEAMMATES#12981, as I used their work to formulate my solution.

Copy link

github-actions bot commented Jul 1, 2024

Hi @itstrueitstrueitsrealitsreal, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]
  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@itstrueitstrueitsrealitsreal itstrueitstrueitsrealitsreal changed the title Calculate totals by email [#12894] Calculate msq totals by student email instead of name Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per-recipient stats are calculated based on student name, not email
1 participant