-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if the search service is active in account request search test #12901
Comments
Good First Issue - Notes for Contributors Please note that we allow only one We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it. To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR. If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum. |
We may also want to move the test method into |
Hi, may I work on this issue? Thank you |
can I take the issue? |
@techMedMau Hey Maureen, as you've previously contributed before. Let's leave this for a new contributor. @traitsisgiorgos Feel free to submit a PR for this. |
thanks!! |
Hey , I am a beginner in open source having experience in java. |
@AggarwalNeelesh Hi, thank you for your interest. Let's give @traitsisgiorgos some time to try to do this. If they decide not to continue with this, you may try to tackle this issue. |
Can I ask you a question ? |
We also want to move the method to the correct file? |
Hello, may I work on this issue? |
Hi @traitsisgiorgos, yes, we may want to move it over to |
Hey, @simranfarrukh, thank you for your interest. @traitsisgiorgos is working on this right now. If you want, you can consider handling a different issue. |
Is this issue still available to be worked on? I would like to work on it with my team for a class project! |
[TEAMMATES#12901] Check if the search service is active in account request search test
Hello, @EmilyMSong. @traitsisgiorgos is currently working on this right now. Nevertheless, if you would still like to contribute, there are other issues that you can consider working on. |
…oleSystem to AccountRequestSearchIT class
Hi, @jayasting98. I am looking to work on this project and I am trying to get I have made the changes locally, and it seems that #13101 also remedies this issue, but has not been merged in. Would it be possible to work on this issue? Thanks! |
…rch test (#13101) * added check for active search service in account request search test * moved account request search test to AccountRequestSearchIT and updated variables and asserts accordingly * Add caution note to instructor email copies and remove hyperlinks * updated account request test constructor to be consistent with latest commits * fixed style errors * fixed compiler errors * fixed assertion error and style * fixed linter errors * Revert "Add caution note to instructor email copies and remove hyperlinks" This reverts commit 232c757. --------- Co-authored-by: Carolyn Liu <[email protected]> Co-authored-by: Anna Zhang <[email protected]> Co-authored-by: DS <[email protected]> Co-authored-by: Wei Qing <[email protected]>
Currently,
AccountRequestsDbIT::testSqlInjectionSearchAccountRequestsInWholeSystem
does not check if the search service is active.teammates/src/it/java/teammates/it/storage/sqlapi/AccountRequestsDbIT.java
Lines 196 to 209 in 2342189
This leads to the following failing test if you try to test locally without the search service.
To fix this, we can check if the search service is active, before running the rest of the test, like in the following.
teammates/src/it/java/teammates/it/storage/sqlsearch/AccountRequestSearchIT.java
Lines 117 to 123 in 2342189
The text was updated successfully, but these errors were encountered: