Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12901] Added Check for Active Search Service #13136

Conversation

itstrueitstrueitsrealitsreal
Copy link
Contributor

Fixes #12901

Outline of Solution

As discussed in the issue, I added a check for an active search service before the rest of AccountRequestsDbIT::testSqlInjectionSearchAccountsRequestsInWholeSystem ran, but I did not shift the test to AccountRequestSearchIT as the test utilised methods from the accountRequestDb class, which I feel should not be put into AccountRequestsDbIT as it has tests which make use of database related functionality.

@weiquu
Copy link
Contributor

weiquu commented Jun 28, 2024

Merged #13101 as it came first

@weiquu weiquu closed this Jun 28, 2024
@itstrueitstrueitsrealitsreal itstrueitstrueitsrealitsreal deleted the branch-fixSqliTest branch July 9, 2024 16:00
@itstrueitstrueitsrealitsreal itstrueitstrueitsrealitsreal restored the branch-fixSqliTest branch July 9, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if the search service is active in account request search test
2 participants