[#12901] Added Check for Active Search Service #13136
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12901
Outline of Solution
As discussed in the issue, I added a check for an active search service before the rest of
AccountRequestsDbIT::testSqlInjectionSearchAccountsRequestsInWholeSystem
ran, but I did not shift the test toAccountRequestSearchIT
as the test utilised methods from theaccountRequestDb
class, which I feel should not be put intoAccountRequestsDbIT
as it has tests which make use of database related functionality.