Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13126] Fix failing component test cases #13127

Merged
merged 3 commits into from
Jun 11, 2024
Merged

[#13126] Fix failing component test cases #13127

merged 3 commits into from
Jun 11, 2024

Conversation

dishenggg
Copy link
Contributor

@dishenggg dishenggg commented Jun 8, 2024 •
edited
Loading

Fixes #13126

Outline of Solution

  • delete account on test teardown
  • Give logs in UpdateFeedbackSessionLogsActionIT a unique sorting order

@dishenggg dishenggg self-assigned this Jun 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 8, 2024

Hi @dishenggg, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@dishenggg dishenggg changed the title Fix failing test cases [#13126] Fix failing test cases Jun 8, 2024
@dishenggg dishenggg changed the title [#13126] Fix failing test cases [#13126] Fix failing component test cases Jun 8, 2024
@dishenggg dishenggg marked this pull request as ready for review June 8, 2024 11:35
@dishenggg dishenggg added the s.ToReview The PR is waiting for review(s) label Jun 8, 2024
cedricongjh
cedricongjh approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Jun 11, 2024
@wkurniawan07
Copy link
Member

Will merge as the failure (outdated timezone DB) is not resolvable without another set of change

@wkurniawan07 wkurniawan07 merged commit 7b75dad into TEAMMATES:master Jun 11, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricongjh cedricongjh cedricongjh approved these changes

@wkurniawan07 wkurniawan07 wkurniawan07 approved these changes

Assignees

@dishenggg dishenggg

Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing component tests
3 participants
@dishenggg @wkurniawan07 @cedricongjh