-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12779] Fix notifications update logic #13083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work on this
assert notification != null; | ||
|
||
if (!notification.isValid()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was previously suggested here. I'm not too sure which is better myself though.
Folks, This PR seems to be stalling (no activities for the past 58 days). 🐌 😢 |
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
Part of #12779
Outline of Solution
flushAndEvict
toHibernateUtil.java
EntitiesDb#merge
to print with returned entity to overcome invalid proxy issue for entities with no persistent instance