Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12779] Fix auto persistence during database updates #12852

Closed

Conversation

marquestye
Copy link
Contributor

@marquestye marquestye commented Feb 27, 2024

Part of #12779

Outline of Solution

  • Created getCopy methods for various affected entities
  • Add tests for unintentional persistence

Copy link

Hi @marquestye, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@domlimm domlimm added the s.ToReview The PR is waiting for review(s) label Mar 3, 2024
@weiquu weiquu requested a review from cedricongjh March 4, 2024 05:10
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @marquestye, apologies for being late to review this

I think it would be good to use this opportunity to standardize the update logic for our entities in this PR. Let's place the checking of validity of the entity in the logic layer, while the db layer should handle the entity not found cases, as the db layer should focus on interfacing with the db, while logic layer handles application logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToReview The PR is waiting for review(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants