Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Didn't Account for the Timezone in Session Edit Form component tests #13147

Closed
Respirayson opened this issue Jul 19, 2024 · 0 comments · Fixed by #13148
Closed

Didn't Account for the Timezone in Session Edit Form component tests #13147

Respirayson opened this issue Jul 19, 2024 · 0 comments · Fixed by #13148

Comments

@Respirayson
Copy link
Contributor

Respirayson commented Jul 19, 2024

  • Environment: master branch at commit 61df45a
    image

Steps to reproduce
Running npm run test.

Expected behaviour
All tests are supposed to pass.

Actual behaviour
it('should not adjust the session visibility date and time if submission opening date and time are later') test fails due to the timezone difference.

Additional info

Just need to add .tz(component.model.timeZone)

itstrueitstrueitsrealitsreal pushed a commit to itstrueitstrueitsrealitsreal/teammates that referenced this issue Jul 27, 2024
…m component tests (TEAMMATES#13148)

Update pr.yml

Update pr.yml

Update pr.yml
mingyuanc pushed a commit that referenced this issue Jul 30, 2024
* Add check for closed issue

* Update message

* Rephrase message

* Add logging

* Test

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Add check for closed issue

Update message

Rephrase message

Add logging

Test

Update pr.yml

* [#13147] Didn't Account for the Timezone in Session Edit Form component tests (#13148)

Update pr.yml

Update pr.yml

Update pr.yml

* Update pr.yml

* Update workflow

---------

Co-authored-by: Rayson Yeap <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant