Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructor Edit Session Page: If make session visible is later than submission opening time, automatically default to opening time #12655

Closed
weiquu opened this issue Dec 12, 2023 · 1 comment · Fixed by #13143
Closed

Instructor Edit Session Page: If make session visible is later than submission opening time, automatically default to opening time #12655

weiquu opened this issue Dec 12, 2023 · 1 comment · Fixed by #13143

Comments

@weiquu
Copy link
Contributor

weiquu commented Dec 12, 2023

After creating a session, the visibility is before the submission opening time:
Screenshot 2023-12-12 at 6 25 25 PM

When editing the session, it's possible to have the submission opening time be set earlier, in which case the session visibility time becomes invalid:
Screenshot 2023-12-12 at 6 27 46 PM

I think that in such a scenario, having the session visibility time default to the submission opening time is appropriate behaviour. This is somewhat similar to the case when submission opening time is set to be after submission closing time - in that scenario, submission closing time defaults to submission opening time.

Also open to discussion as to whether this behaviour is expected by the user or not
willzoo added a commit to willzoo/teammates-fork that referenced this issue Feb 11, 2024
@willzoo
Fixed Issue TEAMMATES#12655: Instructor Edit Session Page: If make se…
feb3ae3 
…ssion visible is later than submission opening time, automatically default to opening time
@Respirayson
Copy link
Contributor

hi I would like to work on this

@Respirayson Respirayson mentioned this issue Jul 12, 2024
Merged
mingyuanc pushed a commit that referenced this issue Jul 15, 2024
@Respirayson
[#12655] Instructor Edit Session Page: If make session visible is lat…
61df45a 
…er than submission opening time, automatically default to opening time (#13143)

* Update functionality to ensure session visibility time defaults to submission opening time

* Add unit tests

* Fix linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@weiquu @Respirayson