Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Geant4] Update to 11.2.0 for G4VecGeom IBs #8878

Merged
merged 4 commits into from
Dec 20, 2023
Merged

[Geant4] Update to 11.2.0 for G4VecGeom IBs #8878

merged 4 commits into from
Dec 20, 2023

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2023 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_14_0_X/g4_vecgeom.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Dec 13, 2023

@smuzaffar , Thanks!

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73099c/36466/summary.html
COMMIT: fa1da66
CMSSW: CMSSW_14_0_G4VECGEOM_X_2023-12-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8878/36466/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

CMakeLists.txt:49 (include)


-- Configuring incomplete, errors occurred!
See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/geant4/11.2.0-5724bed141569a525e70bf689e34e4a8/build/CMakeFiles/CMakeOutput.log".
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.siOxhs (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+geant4+11.2.0-5724bed141569a525e70bf689e34e4a8
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.siOxhs (%build)

@smuzaffar
Copy link
Contributor Author

@civanch , looks like new Geant4 version requires vecgeom 1.2.6 [a]. Note that we have issues/test failures with Vecgeom 1.2.6

[a]

CMake Error at cmake/Modules/G4OptionalComponents.cmake:298 (find_package):
  Could not find a configuration file for package "VecGeom" that is
  compatible with requested version "1.2.6".

@civanch
Copy link
Contributor

civanch commented Dec 13, 2023

@smuzaffar , this condition to set minimal VecGeom 1.2.6 was introduce at last minute before G4 11.2 was out. Developers are saying that in VecGeom 1.2.6 important fixes are done to be coherent with G4 11.2.

Several peoples tried gdml geometry files, which I produced in 14_0_X using DD4hep and DB geometry for 2023. This trapezoid description was not changed since long and in all standalone tests they claim no problems.

So, there are two possibilities: a) take this CMakeList.txt from cand02; b) migrate to VecGeom 1.2.6. Of course, b) would be a natural way. Is it possible to try both G4 11.2 and VecGeom 1.2.6 simultaneously?

@smuzaffar
Copy link
Contributor Author

yes , we can test vecgeom 1.2.6 with this update

@cmsbuild
Copy link
Contributor

Pull request #8878 was updated.

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8878 was updated.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73099c/36471/summary.html
COMMIT: 0ffce56
CMSSW: CMSSW_14_0_G4VECGEOM_X_2023-12-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8878/36471/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73099c/36471/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73099c/36471/git-merge-result

Unit Tests

I found 9 errors in the following unit tests:

---> test Miscellanea had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS
---> test DD4hepGeometryTestDriver had ERRORS
and more ...

RelVals

  • 9.0A fatal system signal has occurred: abort signal
  • 25.0A fatal system signal has occurred: abort signal
  • 8.0A fatal system signal has occurred: abort signal
Expand to see more relval errors ...

AddOn Tests

A fatal system signal has occurred: abort signal

----- Begin Fatal Exception 13-Dec-2023 19:19:09 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Input file file:RelVal_Raw_Fake_MC.root could not be opened.
      [b] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBuffer
read from Storage::xread returned 256. Asked to read n bytes: 300 from offset: 0 with file size: 256

----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 13-Dec-2023 19:20:12 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Input file file:RelVal_Raw_Fake_MC.root could not be opened.
      [b] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBuffer
read from Storage::xread returned 256. Asked to read n bytes: 300 from offset: 0 with file size: 256

----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@civanch
Copy link
Contributor

civanch commented Dec 19, 2023

@smuzaffar , our geometry colleagues rolled back modifications they introduced in VecGeom and they now provide VecGeom 1.2.7, which may work with CMSSW.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8878 was updated.

@smuzaffar
Copy link
Contributor Author

@civanch , VecGeom 1.2.7 looks good. Previously failing addon tests and unit tests are now running fine

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73099c/36563/summary.html
COMMIT: b321781
CMSSW: CMSSW_14_0_G4VECGEOM_X_2023-12-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8878/36563/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73099c/36563/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73099c/36563/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 147 lines from the logs
  • Reco comparison results: 61861 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3429858
  • DQMHistoTests: Total failures: 227674
  • DQMHistoTests: Total nulls: 281
  • DQMHistoTests: Total successes: 3201881
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.73 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 12634.0 ): 3.883 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.171 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 0.717 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -1.275 KiB SiStrip/MechanicalView
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 17 / 48 workflows

@smuzaffar
Copy link
Contributor Author

+externals

looks good for G4Vecgeom IBs

@smuzaffar smuzaffar merged commit 1d6eab7 into IB/CMSSW_14_0_X/g4_vecgeom Dec 20, 2023
10 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/g4_vecgeom IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the smuzaffar-patch-14 branch December 20, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smuzaffar @cmsbuild @civanch