Fix bug related to cmsRun exit code with FileReadError

[wddgit]

PR description:

Fix bug related to cmsRun exit code with FileReadError exception. It was returning 8001 instead of 8021. See Issue #42179 for more discussion. Note this bug was introduced in 12_3_X and this PR will need to be backported to cover active releases since then.

PR validation:

An existing unit test was extended to check the exit code after a FileReadError. In the schema evolution tests there is a file that will exhibit such an error and I used that. Otherwise, it is pretty hard to create such a file intentionally (silver lining of an unrelated 13_0_0 ROOT bug). Note that I don't intend to backport the unit test part because the schema evolution unit test it depends on is relatively new.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43579/38221

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

• FWCore/Framework (core)
• IOPool/Input (core)

@smuzaffar, @cmsbuild, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@missirol, @makortel this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[wddgit]

abort test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43579/38224

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #43579 was updated. @cmsbuild, @Dr15Jones, @smuzaffar, @makortel can you please check and sign again.

[wddgit]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f2728/36519/summary.html
COMMIT: e5504fb
CMSSW: CMSSW_14_0_X_2023-12-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43579/36519/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 85 lines from the logs
• Reco comparison results: 20 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3429858
• DQMHistoTests: Total failures: 1373
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3428463
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[makortel]

Usual set of

• spurious differences in outputs of Run-3 wfs *.7 #39803
• Non reproducibility in wf 136.793 #43293

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1