-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mkFit: overlap area candidate re-check and start using the new hit selection V2 in pixelLess iteration #43580
Conversation
into which update-list to put a hit with an overlap.
…selectHitIndicesV2().
…search and for doing hit preselection.
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43580/38225
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages:
@jfernan2, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
-1 Failed Tests: RelVals RelVals-INPUT AddOn RelVals
Expand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...AddOn Tests
Expand to see more addon errors ... |
test parameters: |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-019829/36523/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
all changes are apparently in the .7 (mkFIt) workflow where the pixelLess iteration is enabled; as expected. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
requires cms-data/RecoTracker-MkFit#13
This PR is technical for the default mkFIt setup (running as in production excluding pixelLess).
The goal is to have this in 14_0 pre2 so that a special relval can be requested with pixelLess enabled.
New feature:
Updates in selecHitIndicesV2 (recently added in #43145 ):
Some observations with pixelLess re-enabled