Integrate FED25 handling in electron online reconstruction

[RSalvatico]

PR description:

This PR contains changes needed for the electron online reconstruction to be able to handle errors such as FED25 to flag malfunctioning Pixel modules. With respect to the current way of handling errors, which is maintained via the isActive() method

cmssw/RecoEgamma/EgammaElectronAlgos/src/TrajSeedMatcher.cc

Line 356 in 754d4fb

if (measDet.isActive())

the new method allows us to catch cases where the flagging happens on a per-event basis (i.e., no need to mask those modules permanently via SiPixelQualityRcd).

In addition, if in the future a 2023 MC will be made where the FED25 error is used to simulate the BPIX issue (e.g., via a probability function), with these changes the online electron reconstruction code should be able to handle it correctly.

PR validation:

I observed an improvement in efficiency for electron triggers (such as HLT_Ele32_WPTight_Gsf) when running them with the proposed changes. The sample used for the test was a DY simulation where the issue in the faulty BPIX modules in layers 3 and 4 in 2023 was simulated at the level of the digitizer (i.e., the channels corresponding to the faulty modules produce an error FED25). Some plots can be found here. Please note that the efficiencies are calculated using gen-level electrons and basically no selection, so on an absolute scale they can look low.

The PR also passed some basic runTeMatrix tests.

[RSalvatico]

type egamma

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43555/38156

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @RSalvatico (Riccardo Salvatico) for master.

It involves the following packages:

• RecoEgamma/EgammaElectronAlgos (reconstruction)
• RecoTracker/MeasurementDet (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@Prasant1993, @a-kapoor, @JanFSchulte, @VourMa, @afiqaize, @ebrondol, @mtosi, @dgulhan, @VinInn, @sobhatta, @Sam-Harper, @GiacomoSguazzoni, @rovere, @sameasy, @varuns23, @felicepantaleo, @lgray, @valsdav, @jainshilpi, @mmusich, @missirol, @gpetruc, @ram1123 this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[RSalvatico]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-035d6a/36442/summary.html
COMMIT: e28a089
CMSSW: CMSSW_14_0_X_2023-12-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43555/36442/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3429858
• DQMHistoTests: Total failures: 952
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3428884
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 48 workflows

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

This PR contains changes needed for the electron online reconstruction to be able to handle errors such as FED25 to flag malfunctioning Pixel modules.

out of curiosity, has this any measurable impact on the HLT timing? From the PR report looks like we're running the on demand Strip at HLT clustering more often with these changes (I guess because of more electron seeds?)

[RSalvatico]

This PR contains changes needed for the electron online reconstruction to be able to handle errors such as FED25 to flag malfunctioning Pixel modules.

out of curiosity, has this any measurable impact on the HLT timing? From the PR report looks like we're running the on demand Strip at HLT clustering more often with these changes (I guess because of more electron seeds?)

Yes, it makes sense that there is some increase. I can measure the timing.

[mmusich]

some unrequested (and un-necessary) feedback below.
Also somehow le is a widespread shorthand in tracking code for local error, if the new variables were called lexx and leyy perhaps the code would be slightly less obfuscated.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43555/38177

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #43555 was updated. @mandrenguyen, @jfernan2 can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-035d6a/36464/summary.html
COMMIT: b6367d2
CMSSW: CMSSW_14_0_X_2023-12-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43555/36464/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 13 lines to the logs
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3429858
• DQMHistoTests: Total failures: 955
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3428881
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 48 workflows

[RSalvatico]

@mmusich The impact of these changes on the HLT timing shouldn't be large (see attached plot). I've run it another time and saw a slightly larger difference (~2 ms increase rather than the 0.4 ms you see here), so I guess it's within uncertainties.

[mmusich]

The impact of these changes on the HLT timing shouldn't be large (see attached plot). I've run it another time and saw a slightly larger difference (~2 ms increase rather than the 0.4 ms you see here), so I guess it's within uncertainties.

thank you @RSalvatico

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-035d6a/36516/summary.html
COMMIT: b6367d2
CMSSW: CMSSW_14_0_X_2023-12-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43555/36516/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 95 lines from the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3429858
• DQMHistoTests: Total failures: 952
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3428884
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 48 workflows