Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional entries to .gitignore #43529

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • ignore mac specific files
  • ignore files used by some IDEs

PR validation:

Tested on Mac laptop. The extra files/directories are now ignored by git.

- ignore mac specific files
- ignore files used by some IDEs
@Dr15Jones
Copy link
Contributor Author

assign core

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

I found this modification helpful when using my Mac laptop (plus different IDEs) for CMSSW code development.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43529/38112

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2023

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • .gitignore (core)

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Dec 8, 2023

Looks ok to me. @smuzaffar?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dbfef/36389/summary.html
COMMIT: ca85cdb
CMSSW: CMSSW_14_0_X_2023-12-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43529/36389/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dbfef/36389/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dbfef/36389/git-merge-result

Comparison Summary

Summary:

  • You potentially added 369 lines to the logs
  • Reco comparison results: 29536 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3430794
  • DQMHistoTests: Total failures: 90077
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3340694
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.132 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.244 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.122 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.010 KiB SiStrip/MechanicalView
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 7 / 48 workflows

@makortel
Copy link
Contributor

@smuzaffar Do you have any comments?

@smuzaffar
Copy link
Contributor

@smuzaffar Do you have any comments?

No, change looks good to me

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 31c88c0 into cms-sw:master Dec 15, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants