L1T o2o: fix int/2 bug

[bundocka]

This PR fixes a bug in the L1T o2o where an integer type is being divided by 2 and producing truncated float output.

During the 2023 HI run, the jet seed threshold was set to 5, thus the GT was populated with the incorrect value of 2 instead of 2.5. HI have requested this be fixed retrospectively in the GT (to be followed up with AlCa).

With this fix, future L1TCalo o2o'd payloads will contain the correct values for parameters divided by 2 that take odd numbers in the HW key.

No backport required.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43510/38090

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bundocka for master.

It involves the following packages:

• L1TriggerConfig/L1TConfigProducers (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4338f/36358/summary.html
COMMIT: 13ce0bb
CMSSW: CMSSW_14_0_X_2023-12-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43510/36358/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 135 lines to the logs
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3430794
• DQMHistoTests: Total failures: 1279
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3429493
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1