Emulator cluster firmware style #43363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43363/37834
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43363/37835
|
|
A new Pull Request was created by @SClarkPhysics for master. It involves the following packages:
@srimanob, @epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e84fd7/36005/summary.html Comparison SummarySummary:
|
|
please test The quoted error is with an x509 proxy, which this PR should have no way of affecting. I would imagine/hope the error is temporary |
|
-1 Failed Tests: RelVals RelVals-INPUT AddOn RelValsExpand to see more relval errors ...
RelVals-INPUT
Expand to see more relval errors ...AddOn TestsExpand to see more addon errors ... |
|
Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e84fd7/36211/summary.html Comparison SummarySummary:
|
|
+l1
|
|
Hi @SClarkPhysics @aloeliger @rappoccio |
|
+Upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This was referenced Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the TrackJet Emulation Clustering algorithm to more closely match what is done in firmware. Specifically, it changes the way the binning is done in the ηφ plane. We also change the python config file so that the max eta is appropriately set, which is used in the APx workflow
This has already been merged to cms-l1t-offline:phase2-l1t-integration-13_3_0_pre3 via PR 1170 . See discussion there