-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more all D* geometry >= D98 to use the @relval2026 menu #43498
Conversation
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43498/38073
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@srimanob, @sunilUIET, @cmsbuild, @miquork, @AdrianoDee can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@cmsbuild, please abort |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f21fbe/36335/summary.html Comparison SummarySummary:
|
+Upgrade |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
As privately disccussed with @srimanob I am moving all the phase-2 relvals for geometries >= D98 to use the
@relval2026
menu instead of the fake one. This should avoid having too many spuriousLogWarning
s concerning missing collections in the DQM and validation steps.I don't touch geometries < D98 as it is in any case in the plans to remove them (see also #43251 )
PR validation:
runTheMatrix.py --what upgrade -l 27224.0,26424.0 -t 4 -j 8
runs fine.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backported, not useful to backport.