Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more all D* geometry >= D98 to use the @relval2026 menu #43498

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 5, 2023

PR description:

As privately disccussed with @srimanob I am moving all the phase-2 relvals for geometries >= D98 to use the @relval2026 menu instead of the fake one. This should avoid having too many spurious LogWarnings concerning missing collections in the DQM and validation steps.
I don't touch geometries < D98 as it is in any case in the plans to remove them (see also #43251 )

PR validation:

runTheMatrix.py --what upgrade -l 27224.0,26424.0 -t 4 -j 8 runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backported, not useful to backport.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 5, 2023

test parameters:

  • workflows = 27224.0,26424.0
  • relvals_opt= -w upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43498/38073

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@srimanob, @sunilUIET, @cmsbuild, @miquork, @AdrianoDee can you please review it and eventually sign? Thanks.
@slomeo, @missirol, @Martin-Grunewald, @fabiocos, @makortel this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 5, 2023

please test

@mmusich
Copy link
Contributor Author

mmusich commented Dec 5, 2023

@cmsbuild, please abort

@mmusich
Copy link
Contributor Author

mmusich commented Dec 5, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f21fbe/36335/summary.html
COMMIT: 372d3bb
CMSSW: CMSSW_14_0_X_2023-12-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43498/36335/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@srimanob
Copy link
Contributor

srimanob commented Dec 6, 2023

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild mentioned this pull request Dec 7, 2023
@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b56e76d into cms-sw:master Dec 8, 2023
12 checks passed
@mmusich mmusich deleted the mm_dev_use_relval2026_forDgt98 branch December 8, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants