Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase precision of photon variables to 10 #43511

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

maxgalli
Copy link
Contributor

@maxgalli maxgalli commented Dec 6, 2023

As it was explained in #43253, the photon variables need a certain floating point precision for the Normalizing Flows-based Data-MC correction procedure to perform optimally.
The following variables:
energyErr
ecalPFClusterIso
hcalPFClusterIso
trkSumPtHollowConeDR03
trkSumPtSolidConeDR04

are inputs to the photonID MVA in Run3 and need to be corrected, hence we increase their precision.

…SumPtHollowConeDR03 trkSumPtSolidConeDR04 to 10
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43511/38091

  • This PR adds an extra 20KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2023

A new Pull Request was created by @maxgalli (Massimiliano Galli) for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @vlimant, @simonepigazzini can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor

vlimant commented Dec 7, 2023

enable nano

@vlimant
Copy link
Contributor

vlimant commented Dec 7, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01f95c/36364/summary.html
COMMIT: 8862312
CMSSW: CMSSW_14_0_X_2023-12-06-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43511/36364/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3430794
  • DQMHistoTests: Total failures: 101
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3430671
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 62 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16405
  • DQMHistoTests: Total failures: 88
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16317
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.542 2.539 0.003 ( +0.1% ) 5.29 5.35 -0.9% 2.022 2.156
2500.001 2.688 2.686 0.002 ( +0.1% ) 4.70 4.72 -0.5% 2.052 2.590
2500.002 2.625 2.622 0.003 ( +0.1% ) 4.92 4.94 -0.4% 2.053 2.569
2500.01 1.312 1.310 0.002 ( +0.1% ) 9.76 9.95 -1.9% 2.192 2.271
2500.011 1.729 1.726 0.002 ( +0.1% ) 5.27 5.31 -0.7% 1.957 2.451
2500.012 1.575 1.572 0.003 ( +0.2% ) 7.53 7.62 -1.2% 1.927 2.367
2500.1 2.190 2.187 0.002 ( +0.1% ) 5.30 5.37 -1.4% 1.905 2.009
2500.2 2.304 2.302 0.002 ( +0.1% ) 6.14 6.10 +0.6% 1.752 1.923
2500.21 1.180 1.177 0.003 ( +0.2% ) 4.36 4.37 -0.3% 1.796 2.223
2500.211 1.542 1.540 0.003 ( +0.2% ) 3.82 3.87 -1.1% 1.994 2.288
2500.3 2.059 2.057 0.002 ( +0.1% ) 12.87 12.92 -0.3% 1.913 1.908
2500.31 1.255 1.253 0.002 ( +0.2% ) 20.57 20.69 -0.6% 2.311 2.307
2500.311 1.642 1.639 0.002 ( +0.1% ) 13.63 14.12 -3.5% 2.259 2.386
2500.312 7.025 7.025 0.000 ( +0.0% ) 1.33 1.44 -7.8% 1.648 1.646
2500.313 1.471 1.471 0.000 ( +0.0% ) 5.78 5.77 +0.1% 0.975 0.976
2500.4 2.059 2.057 0.002 ( +0.1% ) 12.90 12.95 -0.4% 1.911 1.903
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.30 1.19 +9.3% 1.296 1.295

@vlimant
Copy link
Contributor

vlimant commented Dec 8, 2023

+1
all expected

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 440af30 into cms-sw:master Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants