-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase precision of photon variables to 10 #43511
Conversation
…SumPtHollowConeDR03 trkSumPtSolidConeDR04 to 10
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43511/38091
|
A new Pull Request was created by @maxgalli (Massimiliano Galli) for master. It involves the following packages:
@cmsbuild, @vlimant, @simonepigazzini can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
enable nano |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01f95c/36364/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
As it was explained in #43253, the photon variables need a certain floating point precision for the Normalizing Flows-based Data-MC correction procedure to perform optimally.
The following variables:
energyErr
ecalPFClusterIso
hcalPFClusterIso
trkSumPtHollowConeDR03
trkSumPtSolidConeDR04
are inputs to the photonID MVA in Run3 and need to be corrected, hence we increase their precision.