EGamma custom nano #42607

swagata87 · 2023-08-18T20:20:14Z

PR description:

This PR introduces EGamma custom nano for offline electron and photon objects, as discussed in [1] during XPOG workshop.

[1] https://indico.cern.ch/event/1263032/contributions/5450868/attachments/2672569/4633289/xpog_EGM.pdf

PR validation:

Checked with [2] for 12434.0

[2]

cmsDriver.py step3 -s RAW2DIGI,L1Reco,RECO,RECOSIM,PAT,NANO,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@nanoAODDQM --conditions auto:phase1_2023_realistic --datatier GEN-SIM-RECO,MINIAODSIM,NANOAODSIM,DQMIO -n 10 --eventcontent RECOSIM,MINIAODSIM,NANOAODSIM,DQM --geometry DB:Extended --era Run3_2023 --customise PhysicsTools/NanoAOD/nano_cff.addExtraEGammaVarsCustomize --filein file:step2.root

PS: Parsing of remainder was implemented as it was needed for some variables (https://cms-talk.web.cern.ch/t/issue-with-parsing-modulo-operator-in-nano/28519)

(With thanks to Giovanni Petrucciani and Riccardo Salvatico for help and useful discussions)

cmsbuild · 2023-08-18T20:27:59Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42607/36656

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): Fix the vidNestedWPBitmap_Fall17V2 for electron in NANOAOD #42606
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/python/photons_cff.py modified in PR(s): Add 4 Isolation variables for Photon to NanoAOD #42255

cmsbuild · 2023-08-18T20:28:25Z

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

swagata87 · 2023-08-19T06:14:27Z

type egamma

cmsbuild · 2023-08-21T17:22:28Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42607/36670

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): Fix the vidNestedWPBitmap_Fall17V2 for electron in NANOAOD #42606
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/python/photons_cff.py modified in PR(s): Add 4 Isolation variables for Photon to NanoAOD #42255

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42607/36670/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42607/36670/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2023-08-21T18:00:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42607/36671

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): Fix the vidNestedWPBitmap_Fall17V2 for electron in NANOAOD #42606
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/python/photons_cff.py modified in PR(s): Add 4 Isolation variables for Photon to NanoAOD #42255

cmsbuild · 2023-08-21T18:00:51Z

Pull request #42607 was updated. @cmsbuild, @simonepigazzini, @mandrenguyen, @clacaputo, @vlimant can you please check and sign again.

PhysicsTools/NanoAOD/python/nano_cff.py

cmsbuild · 2023-08-25T12:36:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42607/36731

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/photons_cff.py modified in PR(s): Add 4 Isolation variables for Photon to NanoAOD #42255

cmsbuild · 2024-02-29T08:18:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42607/39277

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): adding JME nano in autoNano #44087
- File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): TOoLLiP integration #43638, adding JME nano in autoNano #44087
- File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): TOoLLiP integration #43638
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): TOoLLiP integration #43638
- File PhysicsTools/NanoAOD/python/photons_cff.py modified in PR(s): TOoLLiP integration #43638

cmsbuild · 2024-02-29T08:19:13Z

Pull request #42607 was updated. @jfernan2, @miquork, @cmsbuild, @sunilUIET, @AdrianoDee, @srimanob, @subirsarkar, @mandrenguyen can you please check and sign again.

vlimant · 2024-02-29T22:31:57Z

thanks

vlimant · 2024-02-29T22:32:02Z

please test

cmsbuild · 2024-03-01T01:23:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46a15d/37837/summary.html
COMMIT: 698a433
CMSSW: CMSSW_14_1_X_2024-02-29-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42607/37837/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 55 lines to the logs
Reco comparison results: 63 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3338784
DQMHistoTests: Total failures: 1355
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3337407
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 166 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16430
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16430
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 40 log files, 20 edm output root files, 15 DQM output files

Nano size comparison Summary:

Nano ERROR: Missing ref/2500.301-size.json
Nano ERROR: Missing ref/2500.301-size.json
Nano ERROR: Missing ref/2500.315-size.json
Nano ERROR: Missing ref/2500.315-size.json
Nano ERROR: Missing ref/2500.402-size.json
Nano ERROR: Missing ref/2500.402-size.json
| Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
| --- | --- | --- | --- | --- | --- | --- | --- | --- |
| 2500.0 | 2.551 | 2.551 | 0.000 ( +0.0% ) | 5.30 | 5.27 | +0.7% | 2.216 | 2.166 |
| 2500.001 | 2.700 | 2.700 | 0.000 ( +0.0% ) | 4.69 | 4.73 | -0.8% | 2.233 | 2.564 |
| 2500.002 | 2.641 | 2.641 | 0.000 ( +0.0% ) | 4.92 | 4.88 | +0.9% | 2.247 | 2.559 |
| 2500.01 | 1.322 | 1.322 | 0.000 ( +0.0% ) | 9.78 | 9.63 | +1.5% | 2.323 | 2.269 |
| 2500.011 | 1.745 | 1.745 | 0.000 ( +0.0% ) | 5.28 | 5.14 | +2.9% | 2.125 | 2.386 |
| 2500.012 | 1.586 | 1.586 | 0.000 ( +0.0% ) | 7.62 | 7.37 | +3.4% | 2.154 | 2.379 |
| 2500.1 | 2.194 | 2.194 | 0.000 ( +0.0% ) | 5.33 | 5.33 | +0.0% | 2.055 | 2.073 |
| 2500.2 | 2.310 | 2.310 | 0.000 ( +0.0% ) | 6.06 | 6.00 | +1.0% | 1.938 | 1.984 |
| 2500.21 | 1.185 | 1.185 | 0.000 ( +0.0% ) | 4.33 | 4.37 | -0.8% | 1.965 | 2.274 |
| 2500.211 | 1.549 | 1.549 | 0.000 ( +0.0% ) | 3.77 | 3.78 | -0.3% | 2.056 | 2.243 |
| 2500.3 | 2.060 | 2.060 | 0.000 ( +0.0% ) | 12.45 | 12.72 | -2.1% | 1.973 | 1.972 |
| 2500.31 | 1.258 | 1.258 | 0.000 ( +0.0% ) | 20.13 | 20.14 | -0.0% | 2.371 | 2.370 |
| 2500.311 | 1.644 | 1.644 | 0.000 ( +0.0% ) | 13.76 | 13.61 | +1.1% | 2.450 | 2.339 |
| 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.47 | 1.41 | +4.0% | 1.697 | 1.693 |
| 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.60 | 6.99 | -5.6% | 1.050 | 1.045 |
| 2500.314 | 1.157 | 1.157 | 0.000 ( +0.0% ) | 14.44 | 14.42 | +0.1% | 2.216 | 2.181 |
| 2500.4 | 2.060 | 2.060 | 0.000 ( +0.0% ) | 12.51 | 12.60 | -0.8% | 1.804 | 1.928 |
| 2500.401 | 1.817 | 1.817 | 0.000 ( +0.0% ) | 10.35 | 10.75 | -3.8% | 1.501 | 1.827 |
| 2500.5 | 19.575 | 19.575 | 0.000 ( +0.0% ) | 1.24 | 1.19 | +4.2% | 1.362 | 1.361 |

vlimant · 2024-03-01T09:40:51Z

+1

mandrenguyen · 2024-03-01T09:45:23Z

+reconstruction
Relates to nano only, so if xpog is happy, we're happy.

subirsarkar · 2024-03-01T11:17:18Z

+Upgrade

AdrianoDee · 2024-03-01T13:04:48Z

+pdmv
(wf-wise nothing to comment)

cmsbuild · 2024-03-01T13:05:10Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2024-03-01T14:27:54Z

+1

cmsbuild added this to the CMSSW_13_3_X milestone Aug 18, 2023

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Aug 18, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 18, 2023

cmsbuild added egamma reconstruction-pending code-checks-pending and removed code-checks-approved labels Aug 19, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 21, 2023

swagata87 force-pushed the EGammaNano_offline branch from 01e796f to 2f65659 Compare August 21, 2023 17:34

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 21, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 21, 2023

simonepigazzini reviewed Aug 22, 2023

View reviewed changes

PhysicsTools/NanoAOD/python/nano_cff.py Outdated Show resolved Hide resolved

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 25, 2023

cmsbuild removed the code-checks-pending label Aug 25, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 29, 2024

cmsbuild mentioned this pull request Feb 29, 2024

Test workflows for lepton time-life customization of NanoAOD #44263

Merged

cmsbuild added tests-started and removed tests-pending labels Feb 29, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 1, 2024

cmsbuild mentioned this pull request Mar 1, 2024

[NanoAOD,BTVNano] Btvnano integration as customized module #43485

Merged

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Mar 1, 2024

cmsbuild added upgrade-approved and removed upgrade-pending labels Mar 1, 2024

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Mar 1, 2024

cmsbuild added orp-approved and removed orp-pending labels Mar 1, 2024

cmsbuild merged commit 85c8117 into cms-sw:master Mar 1, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EGamma custom nano #42607

EGamma custom nano #42607

swagata87 commented Aug 18, 2023 •

edited

Loading

cmsbuild commented Aug 18, 2023

cmsbuild commented Aug 18, 2023 •

edited

Loading

swagata87 commented Aug 19, 2023

cmsbuild commented Aug 21, 2023

cmsbuild commented Aug 21, 2023

cmsbuild commented Aug 21, 2023

cmsbuild commented Aug 25, 2023

cmsbuild commented Feb 29, 2024

cmsbuild commented Feb 29, 2024

vlimant commented Feb 29, 2024

vlimant commented Feb 29, 2024

cmsbuild commented Mar 1, 2024

vlimant commented Mar 1, 2024

mandrenguyen commented Mar 1, 2024

subirsarkar commented Mar 1, 2024

AdrianoDee commented Mar 1, 2024

cmsbuild commented Mar 1, 2024

rappoccio commented Mar 1, 2024

EGamma custom nano #42607

EGamma custom nano #42607

Conversation

swagata87 commented Aug 18, 2023 • edited Loading

PR description:

PR validation:

cmsbuild commented Aug 18, 2023

cmsbuild commented Aug 18, 2023 • edited Loading

swagata87 commented Aug 19, 2023

cmsbuild commented Aug 21, 2023

cmsbuild commented Aug 21, 2023

cmsbuild commented Aug 21, 2023

cmsbuild commented Aug 25, 2023

cmsbuild commented Feb 29, 2024

cmsbuild commented Feb 29, 2024

vlimant commented Feb 29, 2024

vlimant commented Feb 29, 2024

cmsbuild commented Mar 1, 2024

Comparison Summary

NANO Comparison Summary

vlimant commented Mar 1, 2024

mandrenguyen commented Mar 1, 2024

subirsarkar commented Mar 1, 2024

AdrianoDee commented Mar 1, 2024

cmsbuild commented Mar 1, 2024

rappoccio commented Mar 1, 2024

swagata87 commented Aug 18, 2023 •

edited

Loading

cmsbuild commented Aug 18, 2023 •

edited

Loading