TOoLLiP integration

[ddiaz006]

PR description:

• Add ML-based LLP Jet tagger to Phase-2 Level-1 trigger emulator; codenamed TOoLLiP
• Requires TOoLLiP external integrated here: Add TOoLLiP extra cmsdist#8906
• Compiled object file added under L1Trigger/Phase2L1ParticleFlow/test until above PR is approved
• Presented at L1 Tau-Jets-MET meetings, e.g.
  • https://indico.cern.ch/event/1288096/#9-llp-jet-tagging-status-and-p
  • https://indico.cern.ch/event/1350143/contributions/5683985/
• This model represents a v1 baseline with post-training quantization. We expect to update it with a more realistic firmware implementation.
• Model and expected performance plots shown here: https://github.com/cms-hls4ml/TOoLLiP/blob/main/README.md
• L1T Offline PR: Add Phase-2 Level-1 LLP trigger emulator: TOoLLiP [13_3_0_pre3] cms-l1t-offline/cmssw#1195
• TOoLLiP in cms-hls4ml : https://github.com/cms-hls4ml/TOoLLiP

PR validation:

In progress

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43638/38293

• This PR adds an extra 52KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/Phase2L1ParticleFlow/BuildFile.xml modified in PR(s): Add Phase-2 Level-1 trigger ML MET emulator #43633

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43638/38293/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43638/38293/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43638/38294

• This PR adds an extra 52KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/Phase2L1ParticleFlow/BuildFile.xml modified in PR(s): Add Phase-2 Level-1 trigger ML MET emulator #43633

[cmsbuild]

A new Pull Request was created by @ddiaz006 for master.

It involves the following packages:

• L1Trigger/Phase2L1ParticleFlow (upgrade, l1)

@cmsbuild, @subirsarkar, @srimanob, @aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test with cms-sw/cmsdist#8906

[smuzaffar]

@ddiaz006 , cms-sw/cmsdist#8906 is merged and new library will be available in 12-23-2300 IB.
Please cleanup this PR and remove the L1Trigger/Phase2L1ParticleFlow/test/TOoLLip_emulator_v1.so shared library from history. You need to delete it and squash the changes to get rid of this library

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ae375/36668/summary.html
COMMIT: 3c1d656
CMSSW: CMSSW_14_0_X_2023-12-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43638/36668/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 109 lines from the logs
• Reco comparison results: 26 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 1219
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3246036
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[ddiaz006]

Ok, I have synced this branch with the changes made in the l1toffline CMSSW. The PR in l1toffline was approved and merged yesterday:cms-l1t-offline#1213

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43638/39296

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/Configuration/python/L1Trigger_EventContent_cff.py modified in PR(s): Add l1tPhase2L1CaloEGammaEmulator to the phase 2 L1 event content #43872

[cmsbuild]

Pull request #43638 was updated. @cmsbuild, @aloeliger, @srimanob, @epalencia, @subirsarkar can you please check and sign again.

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ae375/37841/summary.html
COMMIT: 35942a4
CMSSW: CMSSW_14_1_X_2024-02-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43638/37841/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 96 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 56 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3338784
• DQMHistoTests: Total failures: 1352
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3337410
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[ddiaz006]

Is this to be merged in the next IB? Please let me know if I need to complete any further checks.

[aloeliger]

+l1

[subirsarkar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1