Add l1tPhase2L1CaloEGammaEmulator to the phase 2 L1 event content #43872

epalencia · 2024-02-05T17:10:08Z

This PR adds a new collection to the phase-2 L1 event content.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

As for #43869, we are sort of hoping for this content to make it into the scheduled HLT MC production for CMSSW_14_0. Therefore, this PR may need to be backported based on whether or not it can be quickly included in the final build of CMSSW_14_0.

cmsbuild · 2024-02-05T17:10:37Z

cms-bot internal usage

cmsbuild · 2024-02-05T17:18:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43872/38723

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/L1Trigger_EventContent_cff.py modified in PR(s): Phase-2 TauMinator Tau (NNCaloTau) #42840, Add Phase-2 Level-1 trigger ML MET emulator #43633, Add low pt muon fix objects into phase 2 L1 event content. #43869

cmsbuild · 2024-02-05T17:19:06Z

A new Pull Request was created by @epalencia (Enrique Palencia Cortezon) for master.

It involves the following packages:

L1Trigger/Configuration (l1)

@cmsbuild, @epalencia, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

epalencia · 2024-02-05T17:19:33Z

Please test

cmsbuild · 2024-02-05T18:30:33Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba53d1/37226/summary.html
COMMIT: 5c62e94
CMSSW: CMSSW_14_0_X_2024-02-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43872/37226/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

24896.0

----- Begin Fatal Exception 05-Feb-2024 19:00:30 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
   Additional Info:
      [a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved

----- End Fatal Exception -------------------------------------------------

24900.0

----- Begin Fatal Exception 05-Feb-2024 19:01:00 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
   Additional Info:
      [a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved

----- End Fatal Exception -------------------------------------------------

24834.0

----- Begin Fatal Exception 05-Feb-2024 19:04:28 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
   Additional Info:
      [a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

24034.024034.0_TTbar_14TeV+2026D96/step2_TTbar_14TeV+2026D96.log
24834.024834.0_TTbar_14TeV+2026D98/step2_TTbar_14TeV+2026D98.log
20834.020834.0_TTbar_14TeV+2026D88/step2_TTbar_14TeV+2026D88.log

Expand to see more relval errors ...

epalencia · 2024-02-05T19:22:28Z

Please test

cmsbuild · 2024-02-05T20:34:12Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba53d1/37229/summary.html
COMMIT: 5c62e94
CMSSW: CMSSW_14_0_X_2024-02-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43872/37229/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

24896.0

----- Begin Fatal Exception 05-Feb-2024 21:06:59 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
   Additional Info:
      [a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved

----- End Fatal Exception -------------------------------------------------

24900.0

----- Begin Fatal Exception 05-Feb-2024 21:07:32 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
   Additional Info:
      [a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved

----- End Fatal Exception -------------------------------------------------

24834.0

----- Begin Fatal Exception 05-Feb-2024 21:10:23 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
   Additional Info:
      [a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

24034.024034.0_TTbar_14TeV+2026D96/step2_TTbar_14TeV+2026D96.log
20834.020834.0_TTbar_14TeV+2026D88/step2_TTbar_14TeV+2026D88.log
24834.024834.0_TTbar_14TeV+2026D98/step2_TTbar_14TeV+2026D98.log

Expand to see more relval errors ...

cmsbuild · 2024-02-06T10:12:04Z

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

aloeliger · 2024-02-26T10:16:05Z

@skkwan @pallabidas What is the status of a fix for serializing Calo EGamma objects? I am going through today and trying to un-stick L1T PRs and finalize them. Are we ready to retest adding these objects to event content?

skkwan · 2024-02-26T10:51:52Z

@aloeliger @pallabidas We have a fix tested locally that serializes the Calo EGamma objects without errors. We will submit a PR ASAP, only pending one or two changes to the data format of the clusters send to the Correlators that will provide them with the quality bits they need to use.

aloeliger · 2024-03-14T13:11:30Z

Please test with #44390

cmsbuild · 2024-03-14T13:17:01Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba53d1/38134/summary.html
COMMIT: 5c62e94
CMSSW: CMSSW_14_1_X_2024-03-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43872/38134/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba53d1/38134/git-merge-result

aloeliger · 2024-03-14T13:19:24Z

Oh, not even paying attention. @epalencia Could you rebase this when you get the chance?

epalencia · 2024-03-18T11:16:07Z

I'm closing this PR, superseeded by #44450.

add l1tPhase2L1CaloEGammaEmulator to the event content

5c62e94

cmsbuild added this to the CMSSW_14_0_X milestone Feb 5, 2024

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 5, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 5, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 5, 2024

cmsbuild added tests-rejected and removed tests-started labels Feb 5, 2024

cmsbuild added tests-started and removed tests-rejected labels Feb 5, 2024

cmsbuild added tests-rejected and removed tests-started labels Feb 5, 2024

cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_14_1_X Feb 6, 2024

cmsbuild added this to the CMSSW_14_1_X milestone Feb 12, 2024

This was referenced Feb 13, 2024

Add Phase-2 Level-1 trigger ML MET emulator #43633

Merged

Fix LHCInfoPer* PopCons to produce lumi-type IOVs when running in duringFill mode #43837

Merged

skkwan mentioned this pull request Feb 16, 2024

New digitized collections cannot be included in the event content skkwan/phase2-l1Calo-analyzer#13

Closed

2 tasks

This was referenced Feb 21, 2024

Phase-2 TauMinator Tau (NNCaloTau) #42840

Merged

Add emulated calo jets/taus to L1 sequence and event content. #44058

Merged

Adding Phase 2 HPS Tau Emulator #43848

Merged

cmsbuild mentioned this pull request Mar 1, 2024

TOoLLiP integration #43638

Merged

This was referenced Mar 13, 2024

Fix standalone calo barrel EGamma objects cms-l1t-offline/cmssw#1223

Merged

Fix/update standalone calo barrel egamma objects #44390

Merged

cmsbuild added requires-external tests-started and removed tests-rejected labels Mar 14, 2024

cmsbuild added tests-rejected and removed tests-started labels Mar 14, 2024

epalencia mentioned this pull request Mar 18, 2024

Add l1tPhase2L1CaloEGammaEmulator to the phase 2 L1 event content #44450

Merged

epalencia closed this Mar 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add l1tPhase2L1CaloEGammaEmulator to the phase 2 L1 event content #43872

Add l1tPhase2L1CaloEGammaEmulator to the phase 2 L1 event content #43872

epalencia commented Feb 5, 2024

cmsbuild commented Feb 5, 2024 •

edited

Loading

cmsbuild commented Feb 5, 2024

cmsbuild commented Feb 5, 2024

epalencia commented Feb 5, 2024

cmsbuild commented Feb 5, 2024

epalencia commented Feb 5, 2024

cmsbuild commented Feb 5, 2024

cmsbuild commented Feb 6, 2024

aloeliger commented Feb 26, 2024

skkwan commented Feb 26, 2024

aloeliger commented Mar 14, 2024

cmsbuild commented Mar 14, 2024

aloeliger commented Mar 14, 2024

epalencia commented Mar 18, 2024

Add l1tPhase2L1CaloEGammaEmulator to the phase 2 L1 event content #43872

Add l1tPhase2L1CaloEGammaEmulator to the phase 2 L1 event content #43872

Conversation

epalencia commented Feb 5, 2024

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Feb 5, 2024 • edited Loading

cmsbuild commented Feb 5, 2024

cmsbuild commented Feb 5, 2024

epalencia commented Feb 5, 2024

cmsbuild commented Feb 5, 2024

RelVals

RelVals-INPUT

epalencia commented Feb 5, 2024

cmsbuild commented Feb 5, 2024

RelVals

RelVals-INPUT

cmsbuild commented Feb 6, 2024

aloeliger commented Feb 26, 2024

skkwan commented Feb 26, 2024

aloeliger commented Mar 14, 2024

cmsbuild commented Mar 14, 2024

aloeliger commented Mar 14, 2024

epalencia commented Mar 18, 2024

cmsbuild commented Feb 5, 2024 •

edited

Loading