Adding Phase 2 HPS Tau Emulator

[chnielse]

PR description:

This PR adds the Phase-2 HPS Tau emulator - this is the updated, firmware-based version of the Phase2L1Taus package.
The emulator uses a modified version of the HPS (Hadron-plus-strips) algorithm to identify and reconstruct tau candidates for the L1 Trigger, and outputs a standard vector of PFTau objects.

PR to l1t-integration: PR 1175

PR validation:

Basic validation has been done with standard commands:
scram build code-checks and scram build code format
with no warnings or errors due to this code.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43848/38678

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @chnielse for master.

It involves the following packages:

• L1Trigger/Phase2L1ParticleFlow (upgrade, l1)

@srimanob, @aloeliger, @epalencia, @cmsbuild, @subirsarkar can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[epalencia]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2f76e/37190/summary.html
COMMIT: 71953a1
CMSSW: CMSSW_14_0_X_2024-02-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43848/37190/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 13 lines from the logs
• Reco comparison results: 40 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248620
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3248598
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

[aloeliger]

+l1

• Reviewed by L1 as part of Phase2 hps tau 13 3 cms-l1t-offline/cmssw#1175

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43848/39058

• This PR adds an extra 72KB to repository

• Found files with invalid states:

  • L1Trigger/Phase2L1ParticleFlow/python/L1HPSPFTauProducer_cfi.py:
    • Added: 32fa87c
    • Modified: 5c7c8fc
    • Deleted: eb48cd2
  • L1Trigger/Phase2L1ParticleFlow/plugins/L1HPSPFTauProducer.cxx:
    • Added: 32fa87c
    • Modified: 9c7f37e, 2263ddb, 190d637, 7f46200, 71953a1
    • Deleted: 5c7c8fc

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/Configuration/python/L1Trigger_EventContent_cff.py modified in PR(s): Add Phase-2 Level-1 trigger ML MET emulator #43633, Add l1tPhase2L1CaloEGammaEmulator to the phase 2 L1 event content #43872, Add emulated calo jets/taus to L1 sequence and event content. #44058
  • File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): Add Phase-2 Level-1 trigger ML MET emulator #43633, Add emulated calo jets/taus to L1 sequence and event content. #44058

[cmsbuild]

Pull request #43848 was updated. @subirsarkar, @cmsbuild, @aloeliger, @epalencia, @srimanob can you please check and sign again.

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2f76e/37691/summary.html
COMMIT: 3379c87
CMSSW: CMSSW_14_1_X_2024-02-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43848/37691/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 17 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 63 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3245365
• DQMHistoTests: Total failures: 1192
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3244151
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

• Reviewed by L1 as part of Phase2 hps tau 13 3 cms-l1t-offline/cmssw#1175
• @cms-sw/upgrade-l2 FYI

[subirsarkar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1