Phase2 hps tau 13 3 #1175

chnielse · 2023-10-30T13:41:48Z

PR description:

This PR adds the Phase-2 HPS Tau emulator - this is the updated, firmware-based version of the Phase2L1Taus package.
The emulator uses a modified version of the HPS (Hadron-plus-strips) algorithm to identify and reconstruct tau candidates for the L1 Trigger, and outputs a standard vector of PFTau objects.

PR validation:

Basic validation has been done with standard commands:
scram build code-checks and scram build code format
with no warnings or errors due to this code.

triggerDoctor · 2023-10-30T14:10:52Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -j 8`

triggerDoctor · 2023-10-30T14:13:34Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks`

I found no issues with the headers!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 check-headers`

triggerDoctor · 2023-10-30T14:13:46Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no files with code format issues!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 code-format-all`

aloeliger · 2023-11-08T10:25:45Z

L1Trigger/Phase2L1ParticleFlow/interface/taus/L1HPSPFTauEmulator.h

+  class Particle {
+  public:
+    pt_t hwPt;
+    etaphi_t hwEta;
+    etaphi_t hwPhi;
+    type_t hwId;
+    dz_t hwZ0;
+
+    Particle() : hwPt(0), hwEta(0), hwPhi(0), hwId(0), hwZ0() {}
+    Particle(pt_t pt, etaphi_t eta, etaphi_t phi, type_t id, dz_t z0)
+        : hwPt(pt), hwEta(eta), hwPhi(phi), hwId(id), hwZ0(z0) {}
+
+    pt_t pt() const { return hwPt; }
+
+    etaphi_t phi() const { return hwPhi; }
+
+    etaphi_t eta() const { return hwEta; }
+    type_t id() const { return hwId; }
+    dz_t z0() const { return hwZ0; }
+  };
+
+  //template classes
+  class Tau : public Particle {
+  public:
+    Tau(pt_t pt, etaphi_t eta, etaphi_t phi, type_t id, dz_t z0) : Particle(pt, eta, phi, id, z0) {}
+    ap_uint<5> seed_index;
+    pt_t seed_pt;
+    etaphi_t seed_eta;
+    etaphi_t seed_phi;
+    dz_t seed_z0;
+  };


Have you checked if there are any existing particle candidates in the data formats that you could use here instead? We have a lot of hardware representations of different particles so I would wonder if this is truly necessary.

After looking into it, there are existing options in the dataformats that I can use - currently switching to these and making sure outputs are unchanged, and will update once that's done.

aloeliger · 2023-11-08T10:27:51Z

L1Trigger/Phase2L1ParticleFlow/interface/taus/L1HPSPFTauEmulator.h

+  static const detaphi_t TWOPI = 3.14159 * 2. * etaphi_base;
+  static const detaphi_t PI = 3.14159 * etaphi_base;


Silly question, but is there some reason we use pi to this precision instead of some standard library representation?

aloeliger · 2023-11-08T10:32:31Z

L1Trigger/Phase2L1ParticleFlow/plugins/L1HPSPFTauProducer.cxx

+
+  //adding collection
+  std::vector<edm::Ptr<l1t::PFCandidate>> particles;
+  for(unsigned i = 0; i < (*l1PFCandidates).size(); i++) {


Mayeb this is a stylistic thing on my part, but does edm::Ptr not allow element access with ->?

Using -> here gives an error during compilation, so probably best left as is.

aloeliger · 2023-11-08T10:33:18Z

L1Trigger/Phase2L1ParticleFlow/plugins/L1HPSPFTauProducer.cxx

+
+}
+
+L1HPSPFTauProducer::~L1HPSPFTauProducer() {}


Please remove this empty function and set the destructor to default in the class definition

aloeliger · 2023-11-30T11:06:07Z

@chnielse Any updates on responses to PR review? I see a few changes made, any comments on the other items?

…ormats, plus buxfix to tau cleaning.

aloeliger · 2024-01-17T10:23:31Z

@chnielse Just checking in. Any other planned changes to this PR?

aloeliger · 2024-01-19T11:02:55Z

@chnielse Are all changes to this PR done from your side?

chnielse · 2024-01-19T12:38:17Z

I'm only planning to add converting the tau output to gt format, as that isn't currently there - I should have that done today. Otherwise it's done.

triggerDoctor · 2024-01-23T10:55:47Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -j 8`

triggerDoctor · 2024-01-23T10:59:36Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks`

I found no issues with the headers!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 check-headers`

triggerDoctor · 2024-01-23T10:59:47Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

L1Trigger/L1TTrackMatch/plugins/L1TrackJetClustering.h

Please run scram b code-format to auto-apply code formatting

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 code-format-all`

chnielse · 2024-01-23T15:40:32Z

This isn't one of the files I changed/added, so I don't know why it's returning this now and not before. Not sure if I need to do anything for this?

epalencia · 2024-01-23T15:43:02Z

No, nothing to do from your side. It is ok.

aloeliger · 2024-01-29T09:38:45Z

@chnielse I think at this point this PR is ready to go to main CMSSW. @artlbv, just a heads up on this as this seems like something you would like to be aware of. @epalencia Any further things from your side before we move towards finalizing this?

chnielse · 2024-01-29T09:41:02Z

Should be ready to go from my side.

artlbv · 2024-01-29T09:52:20Z

thanks, also fyi @EmyrClement

epalencia · 2024-01-29T12:08:53Z

@chnielse, nothing from my side, please go ahead and open the PR in master

epalencia · 2024-02-02T11:52:24Z

@chnielse, reminder, could you open the PR in master? Usually, it takes some time to have them reviewed by all parties

aloeliger · 2024-02-14T13:49:28Z

@chnielse In order to start constructing a protoytype branch for the menu team to validate, this PR is being merged immediately to the IB.

chnielse added 3 commits October 30, 2023 14:24

Emulator for Phase-2 HPS Taus

491794f

Minor code fixes to resolve warnings

c952632

Removing extraneous collection

58224b2

aloeliger added Phase-2 Pertains to phase-2 development Emulator Development Emulator development PR labels Nov 8, 2023

aloeliger reviewed Nov 8, 2023

View reviewed changes

Changes made in response to PR comments

8e44a98

aloeliger added the Physics Affecting A PR expected to affect Physics content of the trigger label Nov 30, 2023

Changed to use existing particle candidate implementations from dataf…

fe47850

…ormats, plus buxfix to tau cleaning.

Added GT format encoded tau to PFTau output

48b14ec

chnielse mentioned this pull request Feb 2, 2024

Adding Phase 2 HPS Tau Emulator cms-sw/cmssw#43848

Merged

aloeliger changed the base branch from phase2-l1t-integration-13_3_0_pre3 to phase2-l1t-integration-14_0_0_pre3 February 5, 2024 15:37

EmyrClement mentioned this pull request Feb 9, 2024

Tau and ML MET collections cms-l1-dpg/Phase2-L1Nano#14

Merged

aloeliger merged commit 175840a into cms-l1t-offline:phase2-l1t-integration-14_0_0_pre3 Feb 14, 2024

EmyrClement mentioned this pull request Feb 19, 2024

Add HPS tau emulator to sequence + event content #1210

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2 hps tau 13 3 #1175

Phase2 hps tau 13 3 #1175

chnielse commented Oct 30, 2023

triggerDoctor commented Oct 30, 2023

triggerDoctor commented Oct 30, 2023

triggerDoctor commented Oct 30, 2023

aloeliger Nov 8, 2023

chnielse Dec 5, 2023

aloeliger Nov 8, 2023

aloeliger Nov 8, 2023

chnielse Dec 5, 2023

aloeliger Nov 8, 2023

aloeliger commented Nov 30, 2023

aloeliger commented Jan 17, 2024

aloeliger commented Jan 19, 2024

chnielse commented Jan 19, 2024

triggerDoctor commented Jan 23, 2024

triggerDoctor commented Jan 23, 2024

triggerDoctor commented Jan 23, 2024

chnielse commented Jan 23, 2024

epalencia commented Jan 23, 2024

aloeliger commented Jan 29, 2024

chnielse commented Jan 29, 2024

artlbv commented Jan 29, 2024

epalencia commented Jan 29, 2024

epalencia commented Feb 2, 2024

aloeliger commented Feb 14, 2024

		static const detaphi_t TWOPI = 3.14159 * 2. * etaphi_base;
		static const detaphi_t PI = 3.14159 * etaphi_base;


		}

		L1HPSPFTauProducer::~L1HPSPFTauProducer() {}

Phase2 hps tau 13 3 #1175

Phase2 hps tau 13 3 #1175

Conversation

chnielse commented Oct 30, 2023

PR description:

PR validation:

triggerDoctor commented Oct 30, 2023

triggerDoctor commented Oct 30, 2023

triggerDoctor commented Oct 30, 2023

aloeliger Nov 8, 2023

Choose a reason for hiding this comment

chnielse Dec 5, 2023

Choose a reason for hiding this comment

aloeliger Nov 8, 2023

Choose a reason for hiding this comment

aloeliger Nov 8, 2023

Choose a reason for hiding this comment

chnielse Dec 5, 2023

Choose a reason for hiding this comment

aloeliger Nov 8, 2023

Choose a reason for hiding this comment

aloeliger commented Nov 30, 2023

aloeliger commented Jan 17, 2024

aloeliger commented Jan 19, 2024

chnielse commented Jan 19, 2024

triggerDoctor commented Jan 23, 2024

triggerDoctor commented Jan 23, 2024

triggerDoctor commented Jan 23, 2024

chnielse commented Jan 23, 2024

epalencia commented Jan 23, 2024

aloeliger commented Jan 29, 2024

chnielse commented Jan 29, 2024

artlbv commented Jan 29, 2024

epalencia commented Jan 29, 2024

epalencia commented Feb 2, 2024

aloeliger commented Feb 14, 2024