Fix the vidNestedWPBitmap_Fall17V2 for electron in NANOAOD

[Prasant1993]

PR description:

This PR is to fix the 'vidNestedWPBitmap' variable for electron in NanoAOD in Run2. At present, this is not being correctly filled for Run2. This variable is being filled by mistakenly from this PR #40209 by @swertz for the electron/photon ID variables consistency check. We just found that this bug. Sorry, we didn't realize this mistake before.

PR validation:

runTheMatrix tests have been successfully run for the following workflows :

• runTheMatrix.py -l 12434.0
• runTheMatrix.py -l 11834.0

Backport:

Need input from Cross-POG convenors if backport to CMSSW_12_6_X is needed. It will surely go to NANOAOD V13 production.

Tagging E/Gamma convenors for more input : @swagata87 , @a-kapoor @RSalvatico

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42606/36642

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Prasant1993 (Prasant Kumar Rout) for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[swagata87]

type bugfix

[swagata87]

type egamma

[a-kapoor]

enable nano

[a-kapoor]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a1639/34380/summary.html
COMMIT: f646394
CMSSW: CMSSW_13_3_X_2023-08-21-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42606/34380/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially removed 25 lines from the logs
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3152915
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3152890
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 15526
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 15526
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.448	2.447	0.002 ( +0.1% )	5.11	5.14	-0.7%	2.098	2.154
2500.001	2.555	2.553	0.002 ( +0.1% )	4.62	4.61	+0.2%	2.591	2.517
2500.002	2.500	2.498	0.002 ( +0.1% )	4.87	4.81	+1.3%	2.586	2.514
2500.01	1.242	1.241	0.001 ( +0.1% )	9.58	9.58	-0.0%	2.200	2.232
2500.011	1.606	1.605	0.002 ( +0.1% )	5.23	5.20	+0.5%	2.377	2.405
2500.012	1.488	1.486	0.002 ( +0.1% )	7.51	7.44	+1.0%	2.327	2.335
2500.1	2.161	2.161	0.000 ( +0.0% )	5.22	5.18	+0.8%	1.935	1.923
2500.2	2.271	2.271	0.000 ( +0.0% )	5.99	5.97	+0.3%	1.835	1.836
2500.21	1.147	1.147	0.000 ( +0.0% )	4.32	4.32	+0.0%	2.214	2.268
2500.211	1.505	1.505	0.000 ( +0.0% )	3.77	3.72	+1.1%	2.125	2.118
2500.3	2.009	2.009	0.000 ( +0.0% )	12.18	12.04	+1.2%	1.704	1.697
2500.31	1.211	1.211	0.000 ( +0.0% )	19.09	19.06	+0.2%	2.137	2.138
2500.311	1.590	1.590	0.000 ( +0.0% )	13.63	13.77	-1.0%	2.009	2.005
2500.4	2.009	2.009	0.000 ( +0.0% )	12.17	12.18	-0.1%	1.719	1.704

[simonepigazzini]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a1639/34402/summary.html
COMMIT: f646394
CMSSW: CMSSW_13_3_X_2023-08-21-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42606/34402/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3153095
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153073
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially removed 11 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 15526
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 15526
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.448	2.447	0.002 ( +0.1% )	5.19	5.17	+0.4%	1.962	2.097
2500.001	2.555	2.553	0.002 ( +0.1% )	4.65	4.65	+0.2%	1.975	2.515
2500.002	2.500	2.498	0.002 ( +0.1% )	4.83	4.78	+1.0%	1.989	2.494
2500.01	1.242	1.241	0.001 ( +0.1% )	9.70	9.54	+1.7%	1.880	2.186
2500.011	1.606	1.605	0.002 ( +0.1% )	5.23	5.19	+0.9%	1.933	2.383
2500.012	1.488	1.486	0.002 ( +0.1% )	7.47	7.46	+0.1%	1.887	2.333
2500.1	2.161	2.161	0.000 ( +0.0% )	5.20	5.15	+0.9%	1.817	1.945
2500.2	2.271	2.271	0.000 ( +0.0% )	6.00	5.98	+0.2%	1.726	1.834
2500.21	1.147	1.147	0.000 ( +0.0% )	4.34	4.32	+0.5%	1.712	2.215
2500.211	1.505	1.505	0.000 ( +0.0% )	3.80	3.76	+1.0%	1.802	2.109
2500.3	2.009	2.009	0.000 ( +0.0% )	12.26	12.18	+0.7%	1.564	1.696
2500.31	1.211	1.211	0.000 ( +0.0% )	19.46	19.13	+1.7%	1.961	2.123
2500.311	1.590	1.590	0.000 ( +0.0% )	14.22	13.80	+3.0%	2.003	2.001
2500.4	2.009	2.009	0.000 ( +0.0% )	12.21	12.28	-0.6%	1.601	1.698

[simonepigazzini]

+1

Thanks for the fix. There is no Run2 NanoAOD production scheduled, so at the moment for us just having this in the master is ok. Unless you have a particular use case in mind we do not see a need for any backport.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1