Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding JME nano in autoNano #44087

Merged
merged 10 commits into from
Mar 18, 2024
Merged

adding JME nano in autoNano #44087

merged 10 commits into from
Mar 18, 2024

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented Feb 26, 2024

PR description:

aiming at having the JME nano configured with NANO:@JME (tagging @nurfikri89 )

PR validation:

new JMEnano workflow ran OK

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44087/39055

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vlimant for master.

It involves the following packages:

  • Configuration/Applications (operations)
  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @srimanob, @sunilUIET, @AdrianoDee, @hqucms, @fabiocos, @vlimant, @miquork, @rappoccio, @subirsarkar, @davidlange6, @antoniovilela can you please review it and eventually sign? Thanks.
@gpetruc, @makortel, @missirol, @fabiocos, @Martin-Grunewald, @AnnikaStein, @slomeo this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor Author

vlimant commented Feb 26, 2024

enable nano

@vlimant
Copy link
Contributor Author

vlimant commented Feb 26, 2024

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44087/39064

@cmsbuild
Copy link
Contributor

Pull request #44087 was updated. @hqucms, @davidlange6, @fabiocos, @antoniovilela, @srimanob, @subirsarkar, @sunilUIET, @miquork, @vlimant, @AdrianoDee, @rappoccio can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-821dac/37697/summary.html
COMMIT: d37ba7d
CMSSW: CMSSW_14_1_X_2024-02-26-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44087/37697/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16430
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16430
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 40 log files, 20 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.402-size.json
  • Nano ERROR: Missing ref/2500.402-size.json
    | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
    | --- | --- | --- | --- | --- | --- | --- | --- | --- |
    | 2500.0 | 2.551 | 2.551 | 0.000 ( +0.0% ) | 5.23 | 5.27 | -0.7% | 2.133 | 2.226 |
    | 2500.001 | 2.700 | 2.700 | 0.000 ( +0.0% ) | 4.66 | 4.72 | -1.2% | 2.523 | 2.644 |
    | 2500.002 | 2.641 | 2.641 | 0.000 ( +0.0% ) | 4.83 | 4.86 | -0.6% | 2.519 | 2.634 |
    | 2500.01 | 1.322 | 1.322 | 0.000 ( +0.0% ) | 9.52 | 9.72 | -2.0% | 2.203 | 2.245 |
    | 2500.011 | 1.745 | 1.745 | 0.000 ( +0.0% ) | 5.14 | 5.28 | -2.6% | 2.402 | 2.420 |
    | 2500.012 | 1.586 | 1.586 | 0.000 ( +0.0% ) | 7.37 | 7.43 | -0.8% | 2.268 | 2.421 |
    | 2500.1 | 2.194 | 2.194 | 0.000 ( +0.0% ) | 5.25 | 5.32 | -1.4% | 1.962 | 2.060 |
    | 2500.2 | 2.310 | 2.310 | 0.000 ( +0.0% ) | 6.04 | 6.04 | -0.0% | 1.867 | 1.976 |
    | 2500.21 | 1.185 | 1.185 | 0.000 ( +0.0% ) | 4.34 | 4.36 | -0.3% | 2.183 | 2.255 |
    | 2500.211 | 1.549 | 1.549 | 0.000 ( +0.0% ) | 3.75 | 3.74 | +0.1% | 2.223 | 2.331 |
    | 2500.3 | 2.060 | 2.060 | 0.000 ( +0.0% ) | 12.55 | 12.66 | -0.8% | 1.875 | 1.958 |
    | 2500.31 | 1.258 | 1.258 | 0.000 ( +0.0% ) | 19.96 | 20.10 | -0.7% | 2.251 | 2.357 |
    | 2500.311 | 1.644 | 1.644 | 0.000 ( +0.0% ) | 13.41 | 13.39 | +0.2% | 2.328 | 2.434 |
    | 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.36 | 1.41 | -3.3% | 1.688 | 1.685 |
    | 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.90 | 6.14 | +12.3% | 1.038 | 1.035 |
    | 2500.314 | 1.157 | 1.157 | 0.000 ( +0.0% ) | 13.99 | 14.16 | -1.2% | 2.176 | 2.175 |
    | 2500.4 | 2.060 | 2.060 | 0.000 ( +0.0% ) | 12.33 | 12.54 | -1.7% | 1.888 | 1.926 |
    | 2500.401 | 1.817 | 1.817 | 0.000 ( +0.0% ) | 10.70 | 10.15 | +5.4% | 1.807 | 1.779 |
    | 2500.5 | 19.575 | 19.575 | 0.000 ( +0.0% ) | 1.21 | 1.02 | +17.8% | 1.116 | 1.346 |

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-821dac/38198/summary.html
COMMIT: 66528c7
CMSSW: CMSSW_14_1_X_2024-03-16-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44087/38198/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16402
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16402
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 41 log files, 21 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.317-size.json
  • Nano ERROR: Missing ref/2500.317-size.json
  • Nano ERROR: Missing ref/2500.404-size.json
  • Nano ERROR: Missing ref/2500.404-size.json
    | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
    | --- | --- | --- | --- | --- | --- | --- | --- | --- |
    | 2500.0 | 2.548 | 2.548 | 0.000 ( +0.0% ) | 5.17 | 3.32 | +55.4% | 2.213 | 1.911 |
    | 2500.001 | 2.698 | 2.698 | 0.000 ( +0.0% ) | 4.65 | 2.98 | +56.1% | 2.602 | 2.337 |
    | 2500.002 | 2.638 | 2.638 | 0.000 ( +0.0% ) | 4.82 | 3.11 | +54.8% | 2.597 | 2.330 |
    | 2500.01 | 1.318 | 1.318 | 0.000 ( +0.0% ) | 9.68 | 6.30 | +53.7% | 2.283 | 1.997 |
    | 2500.011 | 1.740 | 1.740 | 0.000 ( +0.0% ) | 5.23 | 3.44 | +52.0% | 2.446 | 2.192 |
    | 2500.012 | 1.581 | 1.581 | 0.000 ( +0.0% ) | 7.35 | 5.00 | +47.0% | 2.419 | 2.099 |
    | 2500.1 | 2.192 | 2.192 | 0.000 ( +0.0% ) | 5.21 | 3.34 | +55.8% | 2.064 | 2.055 |
    | 2500.2 | 2.308 | 2.308 | 0.000 ( +0.0% ) | 6.02 | 3.81 | +58.0% | 1.976 | 1.937 |
    | 2500.21 | 1.181 | 1.181 | 0.000 ( +0.0% ) | 4.33 | 2.83 | +52.9% | 2.258 | 1.953 |
    | 2500.211 | 1.545 | 1.545 | 0.000 ( +0.0% ) | 3.73 | 2.20 | +69.4% | 2.339 | 2.054 |
    | 2500.3 | 2.058 | 2.058 | 0.000 ( +0.0% ) | 12.19 | 7.51 | +62.4% | 1.962 | 1.945 |
    | 2500.301 | 2.631 | 2.631 | 0.000 ( +0.0% ) | 10.13 | 5.68 | +78.4% | 1.952 | 1.956 |
    | 2500.31 | 1.254 | 1.254 | 0.000 ( +0.0% ) | 19.15 | 11.95 | +60.2% | 2.356 | 1.949 |
    | 2500.311 | 1.640 | 1.640 | 0.000 ( +0.0% ) | 13.46 | 8.02 | +67.8% | 2.413 | 2.040 |
    | 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.39 | 0.89 | +56.2% | 1.706 | 1.706 |
    | 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.02 | 4.61 | +30.8% | 1.052 | 1.056 |
    | 2500.314 | 1.163 | 1.163 | 0.000 ( +0.0% ) | 14.11 | 8.13 | +73.6% | 2.055 | 1.760 |
    | 2500.315 | 1.758 | 1.758 | 0.000 ( +0.0% ) | 13.62 | 8.35 | +63.2% | 2.307 | 2.345 |
    | 2500.316 | 3.091 | 1.787 | 1.304 ( +73.0% ) | 2.21 | 8.56 | -74.1% | 2.244 | 2.360 |
    | 2500.4 | 2.058 | 2.058 | 0.000 ( +0.0% ) | 12.12 | 7.71 | +57.2% | 1.915 | 1.969 |
    | 2500.401 | 1.824 | 1.824 | 0.000 ( +0.0% ) | 9.87 | 5.85 | +68.7% | 1.700 | 1.809 |
    | 2500.402 | 2.631 | 2.631 | 0.000 ( +0.0% ) | 9.74 | 5.91 | +64.7% | 1.950 | 1.951 |
    | 2500.403 | 5.188 | 2.620 | 2.568 ( +98.0% ) | 1.57 | 6.10 | -74.3% | 1.870 | 1.953 |
    | 2500.5 | 19.575 | 19.575 | 0.000 ( +0.0% ) | 1.19 | 0.78 | +52.1% | 1.364 | 1.351 |

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit e8519e7 into cms-sw:master Mar 18, 2024
13 checks passed
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-821dac/38236/summary.html
COMMIT: 66528c7
CMSSW: CMSSW_14_1_X_2024-03-17-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44087/38236/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16402
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16402
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 41 log files, 21 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.317-size.json
  • Nano ERROR: Missing ref/2500.317-size.json
  • Nano ERROR: Missing ref/2500.404-size.json
  • Nano ERROR: Missing ref/2500.404-size.json
    | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
    | --- | --- | --- | --- | --- | --- | --- | --- | --- |
    | 2500.0 | 2.548 | 2.548 | 0.000 ( +0.0% ) | 5.31 | 5.25 | +1.0% | 2.237 | 2.222 |
    | 2500.001 | 2.698 | 2.698 | 0.000 ( +0.0% ) | 4.72 | 4.74 | -0.5% | 2.654 | 2.247 |
    | 2500.002 | 2.638 | 2.638 | 0.000 ( +0.0% ) | 4.90 | 4.90 | +0.0% | 2.659 | 2.255 |
    | 2500.01 | 1.318 | 1.318 | 0.000 ( +0.0% ) | 9.63 | 9.67 | -0.4% | 2.267 | 2.081 |
    | 2500.011 | 1.740 | 1.740 | 0.000 ( +0.0% ) | 5.25 | 5.25 | -0.1% | 2.419 | 2.124 |
    | 2500.012 | 1.581 | 1.581 | 0.000 ( +0.0% ) | 7.36 | 7.58 | -2.8% | 2.328 | 2.031 |
    | 2500.1 | 2.192 | 2.192 | 0.000 ( +0.0% ) | 5.28 | 5.30 | -0.4% | 2.063 | 2.039 |
    | 2500.2 | 2.308 | 2.308 | 0.000 ( +0.0% ) | 6.05 | 6.05 | +0.0% | 1.970 | 1.933 |
    | 2500.21 | 1.181 | 1.181 | 0.000 ( +0.0% ) | 4.31 | 4.36 | -1.0% | 2.270 | 1.952 |
    | 2500.211 | 1.545 | 1.545 | 0.000 ( +0.0% ) | 3.78 | 3.73 | +1.2% | 2.349 | 2.052 |
    | 2500.3 | 2.058 | 2.058 | 0.000 ( +0.0% ) | 12.58 | 12.59 | -0.1% | 1.962 | 1.936 |
    | 2500.301 | 2.631 | 2.631 | 0.000 ( +0.0% ) | 10.39 | 10.19 | +1.9% | 1.943 | 1.948 |
    | 2500.31 | 1.254 | 1.254 | 0.000 ( +0.0% ) | 20.12 | 19.85 | +1.3% | 2.347 | 2.338 |
    | 2500.311 | 1.640 | 1.640 | 0.000 ( +0.0% ) | 13.57 | 13.34 | +1.7% | 2.436 | 2.428 |
    | 2500.312 | 7.159 | 7.159 | 0.000 ( +0.0% ) | 1.44 | 1.44 | +0.3% | 1.699 | 1.700 |
    | 2500.313 | 1.564 | 1.564 | 0.000 ( +0.0% ) | 6.96 | 5.97 | +16.5% | 1.055 | 1.053 |
    | 2500.314 | 1.163 | 1.163 | 0.000 ( +0.0% ) | 14.29 | 14.20 | +0.7% | 2.061 | 1.811 |
    | 2500.315 | 1.758 | 1.758 | 0.000 ( +0.0% ) | 14.23 | 13.91 | +2.3% | 2.318 | 2.322 |
    | 2500.316 | 3.091 | 1.787 | 1.304 ( +73.0% ) | 2.26 | 13.45 | -83.2% | 1.974 | 2.219 |
    | 2500.4 | 2.058 | 2.058 | 0.000 ( +0.0% ) | 12.49 | 12.53 | -0.3% | 1.842 | 1.852 |
    | 2500.401 | 1.824 | 1.824 | 0.000 ( +0.0% ) | 10.54 | 10.69 | -1.4% | 1.779 | 1.811 |
    | 2500.402 | 2.631 | 2.631 | 0.000 ( +0.0% ) | 10.08 | 10.06 | +0.2% | 1.952 | 1.943 |
    | 2500.403 | 5.188 | 2.620 | 2.568 ( +98.0% ) | 1.57 | 10.35 | -84.8% | 1.849 | 1.948 |
    | 2500.5 | 19.575 | 19.575 | 0.000 ( +0.0% ) | 1.21 | 1.23 | -1.4% | 1.364 | 1.360 |

@Dr15Jones
Copy link
Contributor

This PR appears to have broken several RelVals in the IB: 10224.15, 11024.15, 11634.15, 25202.15

These died in cmsDriver.py with the error

NANO,DQM:@nanoAODDQM
We have determined that this is simulation (if not, rerun cmsDriver.py with --data)
with DB:
entry file:step3_inMINIAODSIM.root
Step: NANO Spec: 
in prepare_nano nanoSequenceMC
Step: DQM Spec: ['@nanoAODDQM']
customising the process with PrepJMECustomNanoAOD_MC from PhysicsTools/NanoAOD/custom_jme_cff
Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-03-18-2300/bin/el8_amd64_gcc12/cmsDriver.py", line 40, in <module>
    run()
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-03-18-2300/bin/el8_amd64_gcc12/cmsDriver.py", line 16, in run
    configBuilder.prepare()
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-03-18-2300/src/Configuration/Applications/python/ConfigBuilder.py", line 2449, in prepare
    self.pythonCfgCode += self.addCustomise()
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-03-18-2300/src/Configuration/Applications/python/ConfigBuilder.py", line 952, in addCustomise
    raise Exception("config "+f+" has no function "+fcn)
Exception: config PhysicsTools/NanoAOD/custom_jme_cff has no function PrepJMECustomNanoAOD_MC

@vlimant vlimant deleted the jme_autonano branch March 19, 2024 12:39
@vlimant
Copy link
Contributor Author

vlimant commented Mar 20, 2024

#44464 will fix this oversight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants