-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPP20][GEOMETRY] Remove deprecated enum arithmetic #44488
[CPP20][GEOMETRY] Remove deprecated enum arithmetic #44488
Conversation
please test for CMSSW_14_1_CPP20_X |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44488/39577
|
A new Pull Request was created by @iarspider for master. It involves the following packages:
@mdhildreth, @bsunanda, @Dr15Jones, @makortel, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The arithmetic on enum is a sign that maybe the value would be better expressed as |
I already merged two similar PRs. In case you change the implementation, please go back to those two as well. |
hold
Will redo using constexprs
…On Wed, Mar 20, 2024, 23:33 antoniovilela ***@***.***> wrote:
The arithmetic on enum is a sign that maybe the value would be better
expressed as constexpr constant. I think it would be good to explore that
approach before going with static_cast.
@iarspider <https://github.com/iarspider>
I already merged two similar PRs. In case you change the implementation,
please go back to those two as well.
—
Reply to this email directly, view it on GitHub
<#44488 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE3NOR53LGF725UMGLI24TYZIFEDAVCNFSM6AAAAABE7IVZ5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJQG43DOMBVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Pull request has been put on hold by @iarspider |
PR description:
Some arithmetic and logic operations on enums are deprecated in C++20. This PR aims to fix these.
PR validation:
Bot tests.