Update the HLT alpaka customisation #44439

fwyzard · 2024-03-17T12:33:33Z

PR description:

Customise the GPU checks to use the AlpakaBackendFilter:

customise the Status_On{CPU|GPU} HLT paths and the DQM_{Ecal|Hcal|Pixel}Reconstruction_v* HLT paths to use the AlpakaBackendProducer and AlpakaBackendFilter modules.

Delete legacy modules and tasks after defining the alpaka ones.
Clean up white space and indentation.

PR validation:

The online HLT menu 2024 v1 was run with and without these changes.

Backport status

To be backported to 14.0.x for data taking

Delete legacy modules and tasks after defining the alpaka ones. Clean up white space and indentation.

fwyzard · 2024-03-17T12:33:45Z

enable gpu

fwyzard · 2024-03-17T12:33:48Z

please test

cmsbuild · 2024-03-17T12:33:59Z

cms-bot internal usage

cmsbuild · 2024-03-17T12:42:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44439/39512

This PR adds an extra 24KB to repository

cmsbuild · 2024-03-17T12:42:24Z

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@silviodonato, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-03-17T15:37:04Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fc90c/38196/summary.html
COMMIT: f2a1c09
CMSSW: CMSSW_14_1_X_2024-03-16-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44439/38196/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 43 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297369
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3297343
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 22 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 39740
DQMHistoTests: Total failures: 986
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 38754
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
Checked 8 log files, 10 edm output root files, 3 DQM output files
TriggerResults: no differences found

Customise the Status_On{CPU|GPU} HLT paths and the DQM_{Ecal|Hcal|Pixel}Reconstruction HLT paths to use the AlpakaBackendProducer and AlpakaBackendFilter modules.

fwyzard · 2024-03-17T16:14:45Z

please test

cmsbuild · 2024-03-17T16:20:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44439/39514

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/customizeHLTforAlpaka.py modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

cmsbuild · 2024-03-17T16:21:01Z

Pull request #44439 was updated. @mmusich, @Martin-Grunewald can you please check and sign again.

cmsbuild · 2024-03-17T19:43:49Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fc90c/38202/summary.html
COMMIT: 378fb2e
CMSSW: CMSSW_14_1_X_2024-03-16-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44439/38202/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

12834.40212834.402_TTbar_14TeV+2024_Patatrack_PixelOnlyAlpaka/step2_TTbar_14TeV+2024_Patatrack_PixelOnlyAlpaka.log
12834.41212834.412_TTbar_14TeV+2024_Patatrack_ECALOnlyAlpaka/step2_TTbar_14TeV+2024_Patatrack_ECALOnlyAlpaka.log

Comparison Summary

Summary:

You potentially removed 93 lines from the logs
Reco comparison results: 37 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297369
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3297349
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 24 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 39740
DQMHistoTests: Total failures: 1025
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 38715
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
Checked 8 log files, 10 edm output root files, 3 DQM output files
TriggerResults: no differences found

fwyzard · 2024-03-17T19:52:39Z

please test with #44387

cmsbuild · 2024-03-17T22:35:42Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fc90c/38203/summary.html
COMMIT: 378fb2e
CMSSW: CMSSW_14_1_X_2024-03-16-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44439/38203/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 102 lines from the logs
Reco comparison results: 64 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297369
DQMHistoTests: Total failures: 1358
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3295991
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 48 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 39740
DQMHistoTests: Total failures: 1488
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 38252
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
Checked 8 log files, 10 edm output root files, 3 DQM output files
TriggerResults: no differences found

Martin-Grunewald · 2024-03-19T04:54:06Z

+1

cmsbuild · 2024-03-19T04:54:31Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-03-19T15:30:33Z

type hlt-integration

antoniovilela · 2024-03-19T15:32:15Z

+1

Update the HLT alpaka customisation

f2a1c09

Delete legacy modules and tasks after defining the alpaka ones. Clean up white space and indentation.

cmsbuild added this to the CMSSW_14_1_X milestone Mar 17, 2024

cmsbuild added hlt-pending pending-signatures orp-pending tests-started code-checks-pending labels Mar 17, 2024

fwyzard mentioned this pull request Mar 17, 2024

Update the HLT alpaka customisation [14.0.x] #44440

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 17, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 17, 2024

Customise the GPU checks to use the AlpakaBackendFilter

378fb2e

Customise the Status_On{CPU|GPU} HLT paths and the DQM_{Ecal|Hcal|Pixel}Reconstruction HLT paths to use the AlpakaBackendProducer and AlpakaBackendFilter modules.

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Mar 17, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 17, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 17, 2024

cmsbuild added tests-rejected and removed tests-started labels Mar 17, 2024

cmsbuild added requires-external tests-started and removed tests-rejected labels Mar 17, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 17, 2024

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Mar 19, 2024

cmsbuild added the hlt-integration label Mar 19, 2024

cmsbuild added orp-approved and removed orp-pending labels Mar 19, 2024

cmsbuild merged commit f190f94 into cms-sw:master Mar 19, 2024
14 checks passed

fwyzard deleted the update_customizeHLTforAlpaka_141x branch April 7, 2024 10:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the HLT alpaka customisation #44439

Update the HLT alpaka customisation #44439

fwyzard commented Mar 17, 2024 •

edited

Loading

fwyzard commented Mar 17, 2024

fwyzard commented Mar 17, 2024

cmsbuild commented Mar 17, 2024 •

edited

Loading

cmsbuild commented Mar 17, 2024

cmsbuild commented Mar 17, 2024

cmsbuild commented Mar 17, 2024

fwyzard commented Mar 17, 2024

cmsbuild commented Mar 17, 2024

cmsbuild commented Mar 17, 2024

cmsbuild commented Mar 17, 2024

fwyzard commented Mar 17, 2024

cmsbuild commented Mar 17, 2024

Martin-Grunewald commented Mar 19, 2024

cmsbuild commented Mar 19, 2024

antoniovilela commented Mar 19, 2024

antoniovilela commented Mar 19, 2024

Update the HLT alpaka customisation #44439

Update the HLT alpaka customisation #44439

Conversation

fwyzard commented Mar 17, 2024 • edited Loading

PR description:

PR validation:

Backport status

fwyzard commented Mar 17, 2024

fwyzard commented Mar 17, 2024

cmsbuild commented Mar 17, 2024 • edited Loading

cmsbuild commented Mar 17, 2024

cmsbuild commented Mar 17, 2024

cmsbuild commented Mar 17, 2024

Comparison Summary

GPU Comparison Summary

fwyzard commented Mar 17, 2024

cmsbuild commented Mar 17, 2024

cmsbuild commented Mar 17, 2024

cmsbuild commented Mar 17, 2024

RelVals-INPUT

Comparison Summary

GPU Comparison Summary

fwyzard commented Mar 17, 2024

cmsbuild commented Mar 17, 2024

Comparison Summary

GPU Comparison Summary

Martin-Grunewald commented Mar 19, 2024

cmsbuild commented Mar 19, 2024

antoniovilela commented Mar 19, 2024

antoniovilela commented Mar 19, 2024

fwyzard commented Mar 17, 2024 •

edited

Loading

cmsbuild commented Mar 17, 2024 •

edited

Loading