[CPP20][ALCA, DB] Remove deprecated enum arithmetic

[iarspider]

PR description:

Some arithmetic and logic operations on enums are deprecated in C++20. This PR aims to fix these.

PR validation:

Bot tests

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44485/39574

• This PR adds an extra 60KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Alignment/Geners (alca)
• CalibFormats/SiStripObjects (alca)
• Calibration/EcalCalibAlgos (alca)
• CondCore/EcalPlugins (db)
• CondCore/PCLConfigPlugins (db)
• CondFormats/PCLConfig (db, alca)

@saumyaphor4252, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@seemasharmafnal, @yuanchao, @mmusich, @tocheng, @threus, @rsreds, @argiro, @rchatter, @adewit, @wang0jin, @JanChyczynski, @PonIlya, @ReyerBand, @thomreis this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d328b/38286/summary.html
COMMIT: 2716a9c
CMSSW: CMSSW_14_1_CPP20_X_2024-03-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44485/38286/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

[perrotta]

There are other such cases, e.g.:

• cmssw/Alignment/Geners/interface/GenericIO.hh

  Line 315 in 2716a9c

  return GenericReader<Stream, State, T, Int2Type<M::Signature &(M::ISPLACEREADABLE | M::ISHEAPREADABLE)>>::

• cmssw/Alignment/Geners/interface/GenericIO.hh

  Line 337 in 2716a9c

  static_assert((M::Signature & (M::ISPOINTER | M::ISSHAREDPTR)) == 0, "can not write pointers to pointers");

• cmssw/Alignment/Geners/interface/GenericIO.hh

  Line 406 in 2716a9c

  static_assert((M::Signature & (M::ISPOINTER | M::ISSHAREDPTR)) == 0, "can not write pointers to pointers");

• cmssw/Alignment/Geners/interface/GenericIO.hh

  Line 417 in 2716a9c

  static_assert((M::Signature & (M::ISPOINTER | M::ISSHAREDPTR)) == 0, "can not read pointers to pointers");

• cmssw/Alignment/Geners/interface/GenericIO.hh

  Lines 612 to 613 in 2716a9c

  	Int2Type<M::IsPointer * 1 + M::IsSharedPtr * 2 + M::IsHeapReadable * 3 +
  	!(M::IsPointer || M::IsSharedPtr || M::IsHeapReadable) * 4>());

• cmssw/Alignment/Geners/interface/ProcessItem.hh

  Lines 338 to 339 in 2716a9c

  	M::Signature &(M::ISPOD | M::ISSTDCONTAINER | M::ISWRITABLE | M::ISPOINTER | M::ISSHAREDPTR | M::ISIOPTR |
  	M::ISPAIR | M::ISSTRING | M::ISTUPLE | M::ISEXTERNAL)>::process(obj, a1, p2, processClassId);

• cmssw/CalibFormats/SiStripObjects/interface/SiStripRegionCabling.h

  Line 165 in 2716a9c

  inline const uint32_t SiStripRegionCabling::layer(const uint32_t index) { return index % ALLLAYERS; }

• cmssw/CalibFormats/SiStripObjects/interface/SiStripRegionCabling.h

  Line 168 in 2716a9c

  return static_cast<SiStripRegionCabling::SubDet>((index / ALLLAYERS) % ALLSUBDETS);

• (etc.)

[iarspider]

@perrotta thanks, I have somehow missed these.

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44485/39591

• This PR adds an extra 60KB to repository

[cmsbuild]

Pull request #44485 was updated. @francescobrivio, @saumyaphor4252, @perrotta, @consuegs can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d328b/38301/summary.html
COMMIT: ca438de
CMSSW: CMSSW_14_1_CPP20_X_2024-03-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44485/38301/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2227 lines to the logs
• Reco comparison results: 119 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297369
• DQMHistoTests: Total failures: 502
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3296847
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

Also here, I think that constexpr would suit better, as suggested by Matti in #44488 (comment)
At least, the could would look nicer reading...
@iarspider please let us know if you intend to pursue that route here

[iarspider]

@perrotta I plan to pursue this route in all the PRs aiming to fix deprecated enum arithmetics - or, at least, where it won't require too many additional changes

[iarspider]

hold

[cmsbuild]

Pull request has been put on hold by @iarspider
They need to issue an unhold command to remove the hold state or L1 can unhold it for all