-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MillePedeAlignmentAlgorithm
: add a unit test for the mille step
#44434
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44434/39510
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@saumyaphor4252, @perrotta, @consuegs, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44afb0/38190/summary.html Comparison SummarySummary:
|
@mmusich the unit test is technically successfull.
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Issue #44188 showed that we're liable against possible changes in the external libraries (
millepede
andgbl
) used for running complex alignment campaigns, as there is no dedicated test for that.This PR transforms the reproducer of issue #44188 into a unit test, using input Z → µµ ALCARECO data and running the
mille
step of the alignment procedure. The test gives also provision for running thepede
one, but for timing reasons this is not exercised in central tests.PR validation:
scram b runtests_test_MilleZmm
runs fine.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, might be backported to CMSSW_14_0_X for monitoring of the data-taking release.