Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0] Another fix to avoid running genfilter with pgen_smear #43591

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

srimanob
Copy link
Contributor

PR description:

This PR is on top of #43562

PR validation:

Dump config from the following cmsDriver, and run.

cmsDriver.py --python_filename PPD-GenericGSmearS-00001_Dump_cfg.py --eventcontent RAWSIM --datatier GEN-SIM --fileout file:PPD-GenericGSmearS-00001.root --conditions 124X_mcRun3_2022_realistic_v12 --beamspot Realistic25ns13p6TeVEarly2022Collision --step GEN:pgen_smear,SIM --geometry DB:Extended --filein file:PPD-GenericNoSmearGEN-00001.root --era Run3 --no_exec --mc -n -1 --dump_python

We get genfilter only from GEN step as expected:

Before fixing:


root [1] LuminosityBlocks->Print("GenFilterInfo_genFilterEfficiencyProducer*")
******************************************************************************
*Tree    :LuminosityBlocks:                                                        *
*Entries :        1 : Total =           95741 bytes  File  Size =      18913 *
*        :          : Tree compression factor =   1.00                       *
******************************************************************************
*Branch  :GenFilterInfo_genFilterEfficiencyProducer__GEN.                    *
*Entries :        1 : BranchElement (see below)                              *
*............................................................................*
*Br    0 :GenFilterInfo_genFilterEfficiencyProducer__GEN.present : Bool_t    *
*Entries :        1 : Total  Size=        819 bytes  File Size  =        134 *
*Baskets :        1 : Basket Size=      92160 bytes  Compression=   1.00     *
*............................................................................*
*Br    1 :GenFilterInfo_genFilterEfficiencyProducer__GEN.obj : GenFilterInfo *
*Entries :        1 : Total  Size=        864 bytes  File Size  =        195 *
*Baskets :        1 : Basket Size=     134144 bytes  Compression=   1.00     *
*............................................................................*
*Branch  :GenFilterInfo_genFilterEfficiencyProducer__SIM.                    *
*Entries :        1 : BranchElement (see below)                              *
*............................................................................*
*Br    2 :GenFilterInfo_genFilterEfficiencyProducer__SIM.present : Bool_t    *
*Entries :        1 : Total  Size=        819 bytes  File Size  =        134 *
*Baskets :        1 : Basket Size=      92160 bytes  Compression=   1.00     *
*............................................................................*
*Br    3 :GenFilterInfo_genFilterEfficiencyProducer__SIM.obj : GenFilterInfo *
*Entries :        1 : Total  Size=        864 bytes  File Size  =        195 *
*Baskets :        1 : Basket Size=     134144 bytes  Compression=   1.00     *
*............................................................................*

After fixing:

root [1] LuminosityBlocks->Print("GenFilterInfo_genFilterEfficiencyProducer*")
******************************************************************************
*Tree    :LuminosityBlocks:                                                        *
*Entries :        1 : Total =           93152 bytes  File  Size =      18396 *
*        :          : Tree compression factor =   1.00                       *
******************************************************************************
*Branch  :GenFilterInfo_genFilterEfficiencyProducer__GEN.                    *
*Entries :        1 : BranchElement (see below)                              *
*............................................................................*
*Br    0 :GenFilterInfo_genFilterEfficiencyProducer__GEN.present : Bool_t    *
*Entries :        1 : Total  Size=        819 bytes  File Size  =        134 *
*Baskets :        1 : Basket Size=      94208 bytes  Compression=   1.00     *
*............................................................................*
*Br    1 :GenFilterInfo_genFilterEfficiencyProducer__GEN.obj : GenFilterInfo *
*Entries :        1 : Total  Size=        864 bytes  File Size  =        195 *
*Baskets :        1 : Basket Size=     136704 bytes  Compression=   1.00     *
*............................................................................*

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport to all releases with gen_smear.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 18, 2023

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43591/38246

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/Applications (operations)

@davidlange6, @rappoccio, @fabiocos, @antoniovilela, @cmsbuild can you please review it and eventually sign? Thanks.
@makortel, @fabiocos, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10c470/36552/summary.html
COMMIT: deb9ad2
CMSSW: CMSSW_14_0_X_2023-12-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43591/36552/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants