Materialize terror symbols #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d add test (root-project#6908) * Fix in complex_quartic problem reported in issue root-project#6900 and add test Uncomment some different code that is used to compute the discriminat of the resolvent cubic equation used to find roots of quartic. This code seems to eprforms better. This fixes root-project#6900 Add tests for quartic equations * Update and fix links and spelling in the reference documentation of ROOT::Math::Polynomial * Increate test tolerance for fixing failure observed in i386
The old test statistic headers and classes should not be used anymore, since the test statistics should be created with the higher-level functions `createNLL()` and `createChi2()`. This allows us more flexibility in the implementation, and to phase out the old test statistics classes eventually.
This gives us more freedom when refactoring things to also support code generation with AD. Also apply other code modernizations, like less use of `TString` or delegating constructors.
As done by interpreter/llvm-project/cmake/Modules/CMakePolicy.cmake, but this resolves many warnings when building with builtin_llvm=OFF (but builtin_clang=ON): ``` CMake Warning (dev) at /usr/lib64/cmake/llvm/TableGen.cmake:95 (add_custom_command): Policy CMP0116 is not set: Ninja generators transform DEPFILEs from add_custom_command(). Run "cmake --help-policy CMP0116" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Call Stack (most recent call first): interpreter/llvm-project/clang/cmake/modules/AddClang.cmake:25 (tablegen) interpreter/llvm-project/clang/include/clang/AST/CMakeLists.txt:73 (clang_tablegen) This warning is for project developers. Use -Wno-dev to suppress it. ```
On Windows, attempts to find R in the default installation paths if not found via find_program. Does the same for the R_LIBRARY variable, which may not be reported by the R executable on Windows. Adds an R_SCRIPT variable to provide the path to RScript. This is useful if the parent CMake script wants to call R non-interactively to run a script. Fixed a typo in the comments.
nvc++ issued a warning on the last return statement being unreachable.
The variables present in TError.h are used throughout the ROOT libraries. Anytime one of these variables is requested, e.g. with a simple test such as `python -c "import ROOT; ROOT.kError"`, the interpreter will lookup the corresponding symbol. Previously, the variables were declared and defined in the header directly but were not generating any symbol since the linkage was internal. With this commit, provide external linkage to these variables so that the corresponding symbols are materialized in libCore.so. As a consequence, a huge number of extra lookups by cling is avoided.
|
test parameters:
|
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/master/8ea6ca102c. @smuzaffar, @iarspider, @cmsbuild, @aandvalenzuela can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
please test for CMSSW_14_0_ROOT6_X |
|
looks good, the new unit test https://github.com/cms-sw/cmssw/pull/43596/files#diff-1a5b025f3854995af7ffef6f8cf6461192f3fed170ddcfb0bd41e51a5e13152e works with this update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.