Replace deprecated boost::timer with std::clock

[smuzaffar]

boost::timer has been deprecated [a]. This PR replaces boost::timer with std::clock() which is internally used by boost:timer anyway ( https://github.com/boostorg/timer/blob/9ee4c9cd9dec4f4ab5c38ffb9cb9978427916ee0/include/boost/timer.hpp#L50 ). This should fix the deprecated warnings [a]

[a]

boost/1.80.0-826a207b8543c52970cb1f72d50f068c/include/boost/timer.hpp:21:1: note: '#pragma message: This header is deprecated. Use the facilities in <boost/timer/timer.hpp> instead.'
   21 | BOOST_HEADER_DEPRECATED( "the facilities in <boost/timer/timer.hpp>" )

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43486/38055

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• DQM/CSCMonitorModule (dqm)

@syuvivida, @cmsbuild, @nothingface0, @tjavaid, @rvenditti, @antoniovagnerini can you please review it and eventually sign? Thanks.
@ptcox, @barvic this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43486/38058

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #43486 was updated. @antoniovagnerini, @rvenditti, @syuvivida, @nothingface0, @tjavaid can you please check and sign again.

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43486/38064

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #43486 was updated. @rvenditti, @antoniovagnerini, @nothingface0, @tjavaid, @syuvivida can you please check and sign again.

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-634445/36318/summary.html
COMMIT: 0cf6e2f
CMSSW: CMSSW_14_0_X_2023-12-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43486/36318/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 13434.013434.0_TTbar_14TeV+2021FSPU/step2_TTbar_14TeV+2021FSPU.log
• 14234.014234.0_TTbar_14TeV+2023FSPU/step2_TTbar_14TeV+2023FSPU.log
• 25034.11425034.114_TTbar_14TeV+2026D98PU_OTInefficiency10PC/step2_TTbar_14TeV+2026D98PU_OTInefficiency10PC.log

Expand to see more relval errors ...

• 25034.99

Comparison Summary

Summary:

• You potentially removed 280 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3370032
• DQMHistoTests: Total failures: 76
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3369934
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-634445/36318/summary.html
COMMIT: 0cf6e2f
CMSSW: CMSSW_14_0_X_2023-12-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43486/36318/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 280 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3370032
• DQMHistoTests: Total failures: 76
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3369934
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1