NONLTO: Fix use after delete warning for bqueue

[smuzaffar]

This should fix the warnings [a] for NONLTO based cmssw IBs. @dan131riley hint here helped to identify the issue. We are passing tail by value and on 2nd iteration copy of tail gets deleted (as its ref count reaches 0).

Locally building this changes for nonlto IB does not trigger this warning

Fixes #42404

[a]

  cmssw/src/TrackingTools/PatternTools/interface/bqueue.h:57:14: warning: pointer used after 'void operator delete(void*, std::size_t)' [-Wuse-after-free]
    57 |       if ((--refCount) == 0)
      |              ^~~~~~~~
In member function 'void cmsutils::_bqueue_item<T>::delRef() [with T = std::unique_ptr<int>]',
    inlined from 'void cmsutils::_bqueue_item<T>::delRef() [with T = std::unique_ptr<int>]' at cmssw/src/TrackingTools/PatternTools/interface/bqueue.h:56:10,
    inlined from 'void cmsutils::intrusive_ptr_release(_bqueue_item<T>*) [with T = std::unique_ptr<int>]' at cmssw/src/TrackingTools/PatternTools/interface/bqueue.h:82:15,
    inlined from 'boost::intrusive_ptr<T>::~intrusive_ptr() [with T = cmsutils::_bqueue_item<std::unique_ptr<int> >]' at boost/smart_ptr/intrusive_ptr.hpp:98:44,
    inlined from 'boost::intrusive_ptr<T>& boost::intrusive_ptr<T>::operator=(boost::intrusive_ptr<T>&&) [with T = cmsutils::_bqueue_item<std::unique_ptr<int> >]' at boost/smart_ptr/intrusive_ptr.hpp:122:9,
    inlined from 'void cmsutils::bqueue<T>::push_back(T&&) [with T = std::unique_ptr<int>]' at cmssw/src/TrackingTools/PatternTools/interface/bqueue.h:169:14:
cmssw/src/TrackingTools/PatternTools/interface/bqueue.h:58:9: note: call to 'void operator delete(void*, std::size_t)' here
   58 |         delete this;

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43540/38118

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• RecoTracker/CkfPattern (reconstruction)
• TrackingTools/PatternTools (reconstruction)

@mandrenguyen, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks.
@jhgoh, @HuguesBrun, @felicepantaleo, @abbiendi, @rovere, @missirol, @mtosi, @VourMa, @cericeci, @bellan, @JanFSchulte, @trocino, @dgulhan, @GiacomoSguazzoni, @CeliaFernandez, @ebrondol, @mmusich, @gpetruc, @Fedespring, @VinInn, @andrea21z this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[smuzaffar]

please test for CMSSW_14_0_NONLTO_X

[dan131riley]

@smuzaffar Nice catch!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bea475/36398/summary.html
COMMIT: b9474e1
CMSSW: CMSSW_14_0_X_2023-12-10-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43540/36398/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 25 lines from the logs
• Reco comparison results: 13 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3430794
• DQMHistoTests: Total failures: 79
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3430693
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bea475/36399/summary.html
COMMIT: b9474e1
CMSSW: CMSSW_14_0_NONLTO_X_2023-12-10-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43540/36399/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 224 lines from the logs
• Reco comparison results: 5315 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3430794
• DQMHistoTests: Total failures: 40190
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3390582
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jfernan2]

closes #42404

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1