Use likelihood fit instead of chi-square fit in PVValidation

[smuzaffar]

This should fix the unit test failure for slc7 IB (see #43106 and #43577 )

[smuzaffar]

please test for slc7_amd64_gcc12

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43588/38241

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• Alignment/OfflineValidation (alca)

@consuegs, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@adewit, @mmusich, @tocheng, @yuanchao, @tlampen, @rsreds this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-79a965/36539/summary.html
COMMIT: 7cd352e
CMSSW: CMSSW_14_0_X_2023-12-17-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43588/36539/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 103 lines from the logs
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3429858
• DQMHistoTests: Total failures: 1205
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3428631
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-79a965/36538/summary.html
COMMIT: 7cd352e
CMSSW: CMSSW_14_0_X_2023-12-17-0000/slc7_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43588/36538/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 54 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 62836 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3429858
• DQMHistoTests: Total failures: 160567
• DQMHistoTests: Total nulls: 258
• DQMHistoTests: Total successes: 3269011
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 6.132 KiB( 49 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.127 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 12634.0 ): 5.430 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 141.044 ): -0.016 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 250202.181 ): 0.288 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.303 KiB SiStrip/MechanicalView
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 17 / 48 workflows

[perrotta]

@mmusich you are the author of this code: it seems perfectly fine to me using likelihood instead of chisquare (likelihood is also already used in the second fit at L245), but if you have any issue please speak up. Otherwise this PR can be signed.

[mmusich]

@perrotta no objections.

[perrotta]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1