[DT Emulator] First cleaned version AMv2 with SL2 #43390

jfernan2 · 2023-11-24T17:43:19Z

PR description:

This PR integrates the new version (v2) of the Analytical Method for the Phase-2 DT Emulator.

It has been presented in the DT Upgrade (trigger primitives and test systems)[1] and in the Level-1 Muon DPG meeting [2].

Needs data files from PR cms-data/L1Trigger-DTTriggerPhase2#3

Credits of the code to @jaimeleonh [3], SL2 emulation addition from [4] and theta coordinates fix from @mcepeda

PR validation:

The software goes hand by hand with the developments being implemented in the firmware. In links [1] and [2] are presented performance results with the new AMv2 algorithm :

In simulation with the emulator
Comparing emulator and firmware in the laboratory
Similar (or even improved) performance w.r.t. previous AM version (v1, already in CMSSW)

[1] https://indico.cern.ch/event/1262475/contributions/5308462/attachments/2607937/4505149/230309_NewAM_DTUpgrade_JLH.pdf
[2] https://indico.cern.ch/event/1263362/contributions/5305755/attachments/2607489/4504221/230308_NewAM_L1MuonDPG_JLH.pdf

[3] https://github.com/jaimeleonh/cmssw/tree/AM_12_4_2_new_fitter
[4] https://github.com/jfernan2/cmssw/tree/AM_12_4_2_new_fitter_withThetas

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport needed

…tion of k, z and zCMSSW.

cmsbuild · 2023-11-24T17:43:39Z

@jfernan2, CMSSW_14_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

cmsbuild · 2023-11-24T17:49:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43390/37887

This PR adds an extra 80KB to repository

cmsbuild · 2023-11-24T17:50:10Z

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

L1Trigger/DTTriggerPhase2 (l1, upgrade)

@srimanob, @aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@battibass, @missirol, @Martin-Grunewald, @JanFSchulte this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

epalencia · 2023-11-25T09:03:13Z

Please test with cms-data/L1Trigger-DTTriggerPhase2#3

cmsbuild · 2023-11-25T09:51:57Z

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e133a0/36062/summary.html
COMMIT: 38d5507
CMSSW: CMSSW_14_0_X_2023-11-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43390/36062/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

aloeliger · 2023-11-27T10:03:54Z

@jfernan2 There is an error with an unused variable:

L1Trigger/DTTriggerPhase2/src/MuonPathAnalyzerInChamber.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-24-2300/src/L1Trigger/DTTriggerPhase2/src/MuonPathAnalyzerInChamber.cc:720:7: warning: variable 'validHits' set but not used [-Wunused-but-set-variable]

cmsbuild · 2023-11-30T08:09:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43390/37987

This PR adds an extra 136KB to repository

cmsbuild · 2023-11-30T08:09:47Z

Pull request #43390 was updated. @aloeliger, @srimanob, @epalencia can you please check and sign again.

cmsbuild · 2023-11-30T14:52:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e133a0/36189/summary.html
COMMIT: 0efbb6b
CMSSW: CMSSW_14_0_X_2023-11-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43390/36189/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw [LTO] Improve link time by using multiple process for linking cmsdist#8840
@cms-sw Update tag for RecoTracker-FinalTrackSelectors to V01-05-00 cmsdist#8847

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e133a0/36189/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e133a0/36189/git-merge-result

Comparison Summary

Summary:

You potentially added 4348 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 6
DQMHistoTests: Total histograms compared: 21823
DQMHistoTests: Total failures: 36
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 21787
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 5 files compared)
Checked 134 log files, 68 edm output root files, 6 DQM output files
TriggerResults: no differences found

aloeliger · 2023-12-04T15:58:27Z

+l1

Already reviewed as part of [DT Emulator] First cleaned version AMv2 with SL2 cms-l1t-offline/cmssw#1166

srimanob · 2023-12-08T18:00:53Z

I just copy the static log check which relate to L1Trigger/DTTriggerPhase2 here. So you can check and implement in the next PR. I don't think they directly relate to this PR.

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/GlobalCoordsObtainer.cc:222:3: warning: Value stored to 'x_msb' is never read [deadcode.DeadStores]
  222 |   x_msb = from_two_comp(x_msb, PHI_LUT_ADDR_WIDTH);
      |   ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/GlobalCoordsObtainer.cc:225:3: warning: Value stored to 'tanpsi_msb' is never read [deadcode.DeadStores]
  225 |   tanpsi_msb = from_two_comp(tanpsi_msb, PHIB_LUT_ADDR_WIDTH);
      |   ^            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/MuonPathAssociator.cc:592:15: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
  592 |           if (useFitSL3[sl3])
      |               ^~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/MuonPathAssociator.cc:844:19: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
  844 |               if (useFitSL1[sl1])
      |                   ^~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/MuonPathAssociator.cc:905:19: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
  905 |               if (useFitSL3[sl3])
      |                   ^~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/MuonPathAssociator.cc:1011:9: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
 1011 |     if (!useFit[i])
      |         ^~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/MuonPathAssociator.cc:1016:11: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
 1016 |       if (!useFit[j])

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/MuonPathAnalyzerInChamber.cc:245:9: warning: cms.NonFiniteMath [cms.NonFiniteMath]
  245 |     if (isnan(jm_x))
      |         ^
1 warning generated.

srimanob · 2023-12-08T18:01:03Z

+Upgrade

cmsbuild · 2023-12-08T18:01:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

jfernan2 · 2023-12-11T14:53:02Z

Thanks @srimanob
Indeed it is not related to this PR but I will implement a fix for that in the next iteration

rappoccio · 2023-12-11T15:38:29Z

+1

jfernan2 and others added 6 commits October 16, 2023 17:02

Forward port to 13_3_0 of branch AMv2

53fccbb

Remove commented code

85d3cc4

Move cout to LogInfo

5ada2dc

Changes to read laterality LUT

e893f14

Small fixes to theta coordinates: scale on zCMSSW and kCMSSW, calcula…

066b144

…tion of k, z and zCMSSW.

Code format for last commit

38d5507

cmsbuild changed the base branch from CMSSW_14_0_X to master November 24, 2023 17:43

cmsbuild added this to the CMSSW_14_0_X milestone Nov 24, 2023

cmsbuild added l1-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Nov 24, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 24, 2023

cmsbuild added tests-started requires-external and removed tests-pending labels Nov 25, 2023

cmsbuild added tests-rejected and removed tests-started labels Nov 25, 2023

Removal of unused variable validHits

c14455c

cmsbuild removed tests-rejected requires-external labels Nov 27, 2023

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 30, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 30, 2023

cmsbuild added tests-approved and removed tests-started labels Nov 30, 2023

cmsbuild added l1-approved and removed l1-pending labels Dec 4, 2023

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Dec 8, 2023

cmsbuild added orp-approved and removed orp-pending labels Dec 11, 2023

cmsbuild merged commit 720c0bb into cms-sw:master Dec 11, 2023
11 checks passed

rappoccio mentioned this pull request Dec 11, 2023

Add new LUTs for AMv2 cms-data/L1Trigger-DTTriggerPhase2#3

Merged

jfernan2 added a commit to jfernan2/cmssw that referenced this pull request Dec 11, 2023

Fix static warnings detected during cms-sw#43390

e9459dc

jfernan2 mentioned this pull request Dec 11, 2023

Fix static warnings on DT L1T #43544

Merged

This was referenced Dec 12, 2023

[boost] Change mpl::integral_c to boost::integral_constant to avoid Clang16 cms-sw/cmsdist#8873

Merged

[Geant4] Update to 11.2.0 for G4VecGeom IBs cms-sw/cmsdist#8878

Merged

zhenbinwu pushed a commit to zhenbinwu/cmssw that referenced this pull request Feb 14, 2024

Fix static warnings detected during cms-sw#43390

9df2e81

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DT Emulator] First cleaned version AMv2 with SL2 #43390

[DT Emulator] First cleaned version AMv2 with SL2 #43390

jfernan2 commented Nov 24, 2023

cmsbuild commented Nov 24, 2023

cmsbuild commented Nov 24, 2023

cmsbuild commented Nov 24, 2023

epalencia commented Nov 25, 2023

cmsbuild commented Nov 25, 2023

aloeliger commented Nov 27, 2023

cmsbuild commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

aloeliger commented Dec 4, 2023

srimanob commented Dec 8, 2023

srimanob commented Dec 8, 2023

cmsbuild commented Dec 8, 2023

jfernan2 commented Dec 11, 2023

rappoccio commented Dec 11, 2023

[DT Emulator] First cleaned version AMv2 with SL2 #43390

[DT Emulator] First cleaned version AMv2 with SL2 #43390

Conversation

jfernan2 commented Nov 24, 2023

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Nov 24, 2023

cmsbuild commented Nov 24, 2023

cmsbuild commented Nov 24, 2023

epalencia commented Nov 25, 2023

cmsbuild commented Nov 25, 2023

Clang Build

aloeliger commented Nov 27, 2023

cmsbuild commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

Comparison Summary

aloeliger commented Dec 4, 2023

srimanob commented Dec 8, 2023

srimanob commented Dec 8, 2023

cmsbuild commented Dec 8, 2023

jfernan2 commented Dec 11, 2023

rappoccio commented Dec 11, 2023