Remove ACE dependence [$300]

[Winfidonarleyan]

TASK

• ASSERT - feat(Core/Sockets): replace ACE_ASSERT to default core ASSERT #4950
• Configuration - feat(Core/Config): rework config and delete ACE inherited #4608
• Method_Request - feat(Core/MapUpdate): switch from ACE_Method_Request to PCQ #3459
• Stack_Trace refactor(Core/Misc): replace ace network to boost asio #6574
• Task feat(Core/Random): port random system from TrinityCore #5454
• Guard_T - feat(Core/Threading): replace ace threading #4821
• Event_Handler (signal) - feat(Core/SignalHandler): Replace ACE signal handling with std #4877
• Based refactor(Core/Misc): replace ace network to boost asio #6574
• TSS_T feat(Core/Random): port random system from TrinityCore #5454
• INET_Addr refactor(Core/Misc): replace ace network to boost asio #6574
• Reactor feat(Deps/Ace): remove ace library. Part 2 #5679
• Acceptor refactor(Core/Misc): replace ace network to boost asio #6574
• Future feat(Core/Database): port TrinityCore database API #5611
• Queue feat(Core/Database): port TrinityCore database API #5611
• Basic_Types
• Semaphore - feat(Core/Soap): delete ACE inherited #4951
• AutoPtr - feat(Core/Misc): remove ACE Auto_Ptr #3454
• OS_NS_time - feat(Core/Time): remove inherited ACE Time #3455
• Atomic_Op - 4a9476b
• Thread (there is a separate issue for this with a 150$ bounty: Core/Threading: Rewrite Threading system [$150 awarded] #99)

The list will be replenished

Steps

• 1. Update acelite, set lib to STATIC and disable incorrect fix std::auto_ptr chore(Deps/Acelite): update to 6.5.10 #3450
• 2. Rework Config feat(Core/Config): improve config #3453
• 3. Delete AutoPtr feat(Core/Misc): remove ACE Auto_Ptr #3454
• 4. Replace Ace Atomic 4a9476b
• 5. Replace Ace Time feat(Core/Time): remove inherited ACE Time #3455
• 6. Replace ACE_Method_Request feat(Core/MapUpdate): switch from ACE_Method_Request to PCQ #3459
• 7. Replace ACE_Configuration feat(Core/Config): rework config and delete ACE inherited #4608
• 8. Replace ACE_Thread_Mutex | ACE_GUARD feat(Core/Threading): replace ace threading #4821
• 9. Replace ACE_Event_Handler feat(Core/SignalHandler): Replace ACE signal handling with std #4877
• 10. Replace ACE_ASSERT feat(Core/Sockets): replace ACE_ASSERT to default core ASSERT #4950
• 11. Delete ACE_Semaphore feat(Core/Soap): delete ACE inherited #4951
• 12. Delete ACE_TSS feat(Core/Random): port random system from TrinityCore #5454
• 13. Delete Future and Queue feat(Core/Database): port TrinityCore database API #5611
• 14. The end feat(Deps/Ace): remove ace library. Part 1 #6980 and feat(Deps/Ace): remove ace library. Part 2 #5679

---

Did you fix this issue? Go claim the $300 bounty on Bountysource.

[FrancescoBorzi]

the bounty here is EXCLUDING the Thread part, which has already 120$ in a separate issue: #99

[FrancescoBorzi]

Commits from @namreeb at CMaNGOS might be useful for this task: https://github.com/cmangos/mangos-wotlk/commits?after=b1ad3bb4e616537a167b9abd191a3a55499d7b50+69&author=namreeb

[FrancescoBorzi]

@abebeos done, thanks. I'm not sure about the expected difficulty of the tasks. I'd need to investigate to determine it

[FrancescoBorzi]

ah yeah right, @Winfidonarleyan what do you think?

[Helias]

Because it is an old library not maintained anymore afaik and now the modern C++ already supports a lot of feature and functionalities that ACE provide.
It is also a static dependency that we keep in the repository, removing it will give us a lot of benefits and modern way to implement different design pattern and minor features.

[Helias]

You are curious, I think this is a good motivation of contributions.
Anyways, I think that @FrancescoBorzi and the other developers can give you more technical details about removing ACE 😉

But it's something that other communities already did with other software, use modern technologies is always a good thing when you remove old dependencies.

[Winfidonarleyan]

This general part for #4302

[Winfidonarleyan]

I done this, need time for port
WarheadCore/WarheadBand@6ef9e4a

[Winfidonarleyan]

For test core without ace use my custom fork https://github.com/WarheadCore/WarheadBand

[Kitzunu]

Soon hehe

[Winfidonarleyan]

Yes yes, after 25.06.2021 i start delete full

[Kitzunu]

👏

[FrancescoBorzi]

congrats @Winfidonarleyan and everyone else who helped with this transition!

[Winfidonarleyan]

congrats @Winfidonarleyan and everyone else who helped with this transition!

Thanks