feat(Core/Threading): replace ace threading

[Winfidonarleyan]

Changes Proposed:

• Replace ACE threading

Issues Addressed:

• Closes Core/Threading: Rewrite Threading system [$150 awarded] #99
• Part Remove ACE dependence [$300] #3451
• After merge need apply feat(GlobalMethods/AzerothCore): switch to new threading system ElunaLuaEngine/Eluna#348

Tests Performed:

• Windows 3 people
  
• In Unix 2 people

How to Test the Changes:

• Check enter in game (priority hight)
• Uptime > 5-10 min

Target Branch(es):

• Master

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

[ghost]

Apparently on Linux std::mutex works just fine but on Windows has some issues?

more about it here
https://stackoverflow.com/questions/14191566/c-mutex-in-namespace-std-does-not-name-a-type

[Winfidonarleyan]

No problem in Win

[Mitradis]

ready?

[Winfidonarleyan]

In win maybe yes

[Mitradis]

Compiling and work, but crashes on ctrl+c still happened.

[Mitradis]

Ok we can merge this i think, after linux user testing.

[Winfidonarleyan]

Okay, totaly replaced

[Winfidonarleyan]

Ready

[Mitradis]

this Pr should help with ctrlc crash? or this problem belongs to another part Ace remove?

Tested, work.

[Winfidonarleyan]

this Pr should help with ctrlc crash? or this problem belongs to another part Ace remove?

No help with CTRL+C. Replace thread only

[FrancescoBorzi]

@azerothcore/testers @azerothcore/developers @mpfans @pklloveyou please check this PR

[ghost]

Tested on Windows 10

Overall no errors or weird behaviour was detected on a 13 minutes uptime server.

• Played a bit around character creation and adding a few items using commands for a class.
• Learnt spells and fought a Gorilla in Scholazar Basin
• Tamed Loque'naraq
• Uptime at the screenshot: 13 minutes

[FrancescoBorzi]

good job @Winfidonarleyan and thank you very much @claudiodfc and @Mitradis for testing this.

As this is quite a big change, I'd like to have more people test this before merging.

[Zoidwaffle]

@Winfidonarleyan : I'm recompiling your latest version now 👍

[Zoidwaffle]

AzerothCore rev. c23fc113f999 2021-03-25 21:33:42 +0700 (mutex branch) (Unix, Release) uptime just passed 40 minutes, which is a new record. I will update later in the evening if it keeps working or not.

Edit: Uptime 2h10m. I'm starting to feel confident it's working now.

[Zoidwaffle]

AC>AzerothCore rev. c23fc113f999 2021-03-25 21:33:42 +0700 (mutex branch) (Unix, Release)
Connected players: 0. Characters in world: 0.
Connection peak: 1.
Server uptime: 4 hour(s) 1 minute(s) 43 second(s).

Yep, it seems good. Well done! 🚀

Edit: Will compile and test with my modules etc. enabled as well.

Edit2: Seems fine, uptime ~2 hours now. I had to fix some SQL for a module, but that was all.

[Winfidonarleyan]

So, all okay?

[Zoidwaffle]

@Winfidonarleyan : yes, it seems to work just fine for me now. Thanks!

[FrancescoBorzi]

@Winfidonarleyan the build is failing

[Winfidonarleyan]

@Winfidonarleyan the build is failing

ElunaLuaEngine/Eluna#348

[Yehonal]

GJ! Have Someone tested it on a live server with medium population?

[FrancescoBorzi]

waiting for @Footman @mpfans and @pklloveyou to test this with players

[mpfans]

I've been testing it for a week and I think we can merge it

[Winfidonarleyan]

@mpfans Thanks for testing