Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Core/Config): rework config and delete ACE inherited #4608

Merged
merged 19 commits into from
Feb 28, 2021

Conversation

Winfidonarleyan
Copy link
Member

@Winfidonarleyan Winfidonarleyan commented Feb 19, 2021

Changes Proposed:

  • Delete ACE_Configuration inherited
  • Full switch to std lib
  • Cherrypick StringConvert from TrinityCore
  • Add CMake macro for copy default and modules configs
  • Add new getters GetOption<bool> and etc
  • Add info about all modules configs after generating sources
  • Add a new folder for all configs configs
  • Add a new folder for all module configs configs/modules

  • New folder for default configs non Windows systems
    image
  • New folder for modules configs non Windows systems
    image

Issues Addressed:

Tests Performed:

  • Builds and in-game

Target Branch(es):

  • Master

Media

  1. New folder configs in Windows
    image
  2. New folder configs/modules in Windows
    image
  3. Config list after CMake source generated
    image
  4. Testing in game
    image

@github-actions github-actions bot added the CORE label Feb 19, 2021
@Winfidonarleyan Winfidonarleyan mentioned this pull request Feb 19, 2021
33 tasks
@Winfidonarleyan Winfidonarleyan marked this pull request as ready for review February 19, 2021 10:40
@FrancescoBorzi
Copy link
Contributor

@Winfidonarleyan the build is failing

@github-actions github-actions bot removed the Cmake label Feb 19, 2021
@Viste
Copy link
Contributor

Viste commented Feb 19, 2021

image

@Mitradis
Copy link
Contributor

jv5l3v9svse-1-kopiya

@Mitradis
Copy link
Contributor

Tested on windows, work.

@mpfans
Copy link
Contributor

mpfans commented Feb 26, 2021

update to b9e132a
and then Merge this PR,Compilation error
image

@Winfidonarleyan
Copy link
Member Author

Re run cmake

@mpfans
Copy link
Contributor

mpfans commented Feb 27, 2021

ubuntu 18.04 test failed....

image

@Winfidonarleyan
Copy link
Member Author

What is your clang? Show full CMake clean log

@FrancescoBorzi
Copy link
Contributor

@mpfans you probably have a compiler that is too old. It compiles fine on Ubuntu 18.04 using clang 6 and gcc 8.4 and higher versions. Older versions are not supported

@FrancescoBorzi FrancescoBorzi merged commit dbefa17 into azerothcore:master Feb 28, 2021
@Winfidonarleyan Winfidonarleyan deleted the config-rework branch February 28, 2021 13:37
FrancescoBorzi pushed a commit to azerothcore/mod-world-chat that referenced this pull request Mar 2, 2021
FrancescoBorzi pushed a commit to azerothcore/mod-item-level-up that referenced this pull request Mar 2, 2021
FrancescoBorzi pushed a commit to azerothcore/mod-gain-honor-guard that referenced this pull request Mar 3, 2021
FrancescoBorzi pushed a commit to azerothcore/mod-pocket-portal that referenced this pull request Mar 3, 2021
FrancescoBorzi pushed a commit to azerothcore/mod-solo-lfg that referenced this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants