-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Core/Config): rework config and delete ACE inherited #4608
Merged
FrancescoBorzi
merged 19 commits into
azerothcore:master
from
Winfidonarleyan:config-rework
Feb 28, 2021
Merged
feat(Core/Config): rework config and delete ACE inherited #4608
FrancescoBorzi
merged 19 commits into
azerothcore:master
from
Winfidonarleyan:config-rework
Feb 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
@Winfidonarleyan the build is failing |
Winfidonarleyan
force-pushed
the
config-rework
branch
from
February 19, 2021 14:20
8a54a72
to
8922d73
Compare
Tested on windows, work. |
update to b9e132a |
Re run cmake |
What is your clang? Show full CMake clean log |
@mpfans you probably have a compiler that is too old. It compiles fine on Ubuntu 18.04 using |
FrancescoBorzi
pushed a commit
to azerothcore/mod-world-chat
that referenced
this pull request
Mar 2, 2021
FrancescoBorzi
pushed a commit
to azerothcore/mod-item-level-up
that referenced
this pull request
Mar 2, 2021
FrancescoBorzi
pushed a commit
to azerothcore/mod-gain-honor-guard
that referenced
this pull request
Mar 3, 2021
FrancescoBorzi
pushed a commit
to azerothcore/mod-pocket-portal
that referenced
this pull request
Mar 3, 2021
FrancescoBorzi
pushed a commit
to azerothcore/mod-solo-lfg
that referenced
this pull request
Mar 3, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
ACE_Configuration
inheritedStringConvert
from TrinityCoreGetOption<bool>
and etcconfigs
configs/modules
Issues Addressed:
Tests Performed:
Target Branch(es):
Media
configs
in Windowsconfigs/modules
in Windows