Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Core/Sockets): replace ACE_ASSERT to default core ASSERT #4950

Merged
merged 5 commits into from
Mar 25, 2021
Merged

feat(Core/Sockets): replace ACE_ASSERT to default core ASSERT #4950

merged 5 commits into from
Mar 25, 2021

Conversation

Winfidonarleyan
Copy link
Member

@Winfidonarleyan Winfidonarleyan commented Mar 23, 2021 •
edited
Loading

Changes Proposed:

  • Replace ACE_ASSERT to default core ASSERT and ABORT

Issues Addressed:

Tests Performed:

image

How to Test the Changes:

  • Try uptime > 15 min ?
  • I don't think it needs to be tested.

Target Branch(es):

  • Master

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

@github-actions github-actions bot added the CORE label Mar 23, 2021
@Winfidonarleyan Winfidonarleyan mentioned this pull request Mar 23, 2021
Closed
33 tasks
@Si1ker Si1ker merged commit 10fa49f into azerothcore:master Mar 25, 2021
@Winfidonarleyan Winfidonarleyan deleted the ace-assert branch March 25, 2021 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancescoBorzi FrancescoBorzi FrancescoBorzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Winfidonarleyan @FrancescoBorzi @Si1ker