Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Deps/Acelite): update to 6.5.10 #3450

Merged
merged 7 commits into from
Nov 11, 2020

Conversation

Winfidonarleyan
Copy link
Member

@Winfidonarleyan Winfidonarleyan commented Sep 8, 2020

CHANGES PROPOSED:

  • Update library acelite to 6.5.10
  • Set library to STATIC (no need ace.lib for *server.exe and all tools`
  • Correct fix for c++17 3a43e8c
  • Maybe fix errors with threads in Win

ISSUES ADDRESSED:

TESTS PERFORMED:

  • Test build in WIN at VS 16.7.1
  • Test in my fork since July 15 (in-game and build)

HOW TO TEST THE CHANGES:

Hmmmmm

  • Build
  • Test in-game ~10 min
  • Try use all .exe files without ace.lib

Target branch(es):

  • Master

How to test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

@Mitradis
Copy link
Contributor

Mitradis commented Nov 10, 2020

Work fine. Without ace.dll (in server folder only libcrypto-1_1-x64.dll libmysql.dll libssl-1_1-x64.dll). But this not fix CTRL+C server crash.

@Si1ker Si1ker merged commit e27201c into azerothcore:master Nov 11, 2020
@Winfidonarleyan Winfidonarleyan deleted the ace-update branch November 11, 2020 20:25
steenburgh added a commit to steenburgh/wiki that referenced this pull request Jan 24, 2021
Kitzunu pushed a commit to azerothcore/wiki that referenced this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants