-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Core/Database): port TrinityCore database API #5611
Conversation
Ready to test without modules with db |
not yet, the build is still failing (including one without modules) |
Clang 6 build failing |
ok then first complete this please: #5671 |
* cherry-pick TrinityCore/TrinityCore@3b5014fdae * cherry-pick small part of TrinityCore/TrinityCore@f4f7e63 Co-Authored-By: Shauren <[email protected]> Co-Authored-By: Treeston <[email protected]>
This reverts commit 52ff891.
Tests performed:
To me, all looks good =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't be reviewing 156 files, putting my trust in the CI and my tests
Very good, big thanks for the test |
merge conflicts again :S |
Fixed conflicts |
This PR removed |
cc @Winfidonarleyan please take a look at this |
I fix today, sorry |
Changes Proposed:
Issues Addressed:
Tests Performed:
How to Test the Changes:
Known Issues and TODO List:
clang-7
.char rename
.char customize
Target Branch(es):
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.