Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Core/Database): port TrinityCore database API #5611

Merged
merged 57 commits into from
Jun 22, 2021

Conversation

Winfidonarleyan
Copy link
Member

@Winfidonarleyan Winfidonarleyan commented May 3, 2021

Changes Proposed:

  • It's about time, hah
  • Port all changes TrinityCore database

Issues Addressed:

Tests Performed:

  • Char (Loading/create/delete)
  • Hunter pets (loading, combat, stable master, rename)

How to Test the Changes:

  • Check char create/rename/customize/delete/loading and other
  • Check all pets functions (rename/add) and other
  • Check character save system

Known Issues and TODO List:

Target Branch(es):

  • Master

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@Winfidonarleyan
Copy link
Member Author

Ready to test without modules with db

@FrancescoBorzi
Copy link
Contributor

Ready to test without modules with db

not yet, the build is still failing (including one without modules)

@Winfidonarleyan
Copy link
Member Author

Ready to test without modules with db

not yet, the build is still failing (including one without modules)

Clang 6 build failing

@FrancescoBorzi
Copy link
Contributor

ok then first complete this please: #5671

@Kitzunu
Copy link
Member

Kitzunu commented Jun 21, 2021

Tests performed:

  • 🟢 Created a character -> Works
  • 🟢 .char rename -> Works
  • 🟢 .char customize -> Works
  • 🟢 .char changerace -> Works (Even though you have mail, but probably not an issue of this PR)
  • 🟢 .char changefaction -> Works
  • 🟢 Talents -> Works
  • 🟢 Glyphs -> Works
  • 🟢 Restarting server -> Works, everything is saved as I left it
  • 🟢 Deleting character -> Works, It's deleted
  • 🟢 Tamed beast -> Works
  • 🟢 Revive Pet -> Works
  • 🟢 Rename Pet -> Works
  • 🟢 Stable -> Works
  • 🟢 Pet talents -> Works
  • 🟢 Restarting server -> Works, Pet still stabled, has new name.
  • 🟢 Out of Stable -> Works

To me, all looks good =)

Copy link
Member

@Kitzunu Kitzunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't be reviewing 156 files, putting my trust in the CI and my tests

@Winfidonarleyan
Copy link
Member Author

Tests performed:

  • 🟢 Created a character -> Works
  • 🟢 .char rename -> Works
  • 🟢 .char customize -> Works
  • 🟢 .char changerace -> Works (Even though you have mail, but probably not an issue of this PR)
  • 🟢 .char changefaction -> Works
  • 🟢 Talents -> Works
  • 🟢 Glyphs -> Works
  • 🟢 Restarting server -> Works, everything is saved as I left it
  • 🟢 Deleting character -> Works, It's deleted
  • 🟢 Tamed beast -> Works
  • 🟢 Revive Pet -> Works
  • 🟢 Rename Pet -> Works
  • 🟢 Stable -> Works
  • 🟢 Pet talents -> Works
  • 🟢 Restarting server -> Works, Pet still stabled, has new name.
  • 🟢 Out of Stable -> Works

To me, all looks good =)

Very good, big thanks for the test

@Helias
Copy link
Member

Helias commented Jun 21, 2021

merge conflicts again :S
let's merge this big PR when we can @Kitzunu @FrancescoBorzi

@Kitzunu
Copy link
Member

Kitzunu commented Jun 21, 2021

Fixed conflicts

@Kitzunu Kitzunu merged commit 9ac6fdd into azerothcore:master Jun 22, 2021
@Winfidonarleyan Winfidonarleyan deleted the db branch July 11, 2021 15:02
@jackpoz
Copy link
Contributor

jackpoz commented Sep 16, 2021

This PR removed * Copyright (C) 2008-2016 TrinityCore <http://www.trinitycore.org/> from a few ported files. Was that supposed to happen ?

@Kitzunu
Copy link
Member

Kitzunu commented Sep 16, 2021

cc @Winfidonarleyan please take a look at this

@Winfidonarleyan
Copy link
Member Author

This PR removed * Copyright (C) 2008-2016 TrinityCore <http://www.trinitycore.org/> from a few ported files. Was that supposed to happen ?

I fix today, sorry

@Winfidonarleyan
Copy link
Member Author

@jackpoz, 52aa0e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move/Port TrinityCore Database API [$165]
7 participants