Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Changelog): add changelog for new features #6518

Merged
merged 9 commits into from
Jun 29, 2021
Merged

docs(Changelog): add changelog for new features #6518

merged 9 commits into from
Jun 29, 2021

Conversation

Winfidonarleyan
Copy link
Member

@Winfidonarleyan Winfidonarleyan commented Jun 23, 2021 •
edited
Loading

Changes Proposed:

Issued

@Winfidonarleyan Winfidonarleyan requested a review from Yehonal June 23, 2021 08:27
@Winfidonarleyan Winfidonarleyan changed the title feat(Doc/Changelog): add changelog for new DB API feat(Doc/Changelog): add changelog for new futures Jun 23, 2021
@Winfidonarleyan Winfidonarleyan marked this pull request as ready for review June 26, 2021 05:25
@Yehonal Yehonal changed the title feat(Doc/Changelog): add changelog for new futures feat(Doc/Changelog): add changelog for new features Jun 26, 2021
Yehonal
Yehonal requested changes Jun 26, 2021
View reviewed changes
Copy link
Member

@Yehonal Yehonal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite my 2 comments. LGTM!

doc/changelog/pendings/changes_1624436208627288700.md Outdated Show resolved Hide resolved
doc/changelog/pendings/changes_1624436916395082900.md Outdated Show resolved Hide resolved
@Yehonal
Copy link
Member

Yehonal commented Jun 26, 2021

Maybe this is also worth to be mentioned: #1338

Since it breaks many old modules/scripts

@Winfidonarleyan
Copy link
Member Author

Maybe this is also worth to be mentioned: #1338

Since it breaks many old modules/scripts

Added info about this

@Yehonal
Copy link
Member

Yehonal commented Jun 27, 2021

The changelogs look very clear now, I'm even testing it with my module

@Winfidonarleyan
Copy link
Member Author

Winfidonarleyan commented Jun 28, 2021 •
edited
Loading

@Yehonal Is there anything else need to add?

@Yehonal
Copy link
Member

Yehonal commented Jun 28, 2021

Tested with the mod-azerothshard and it allowed me to migrate that module (almost).

@FrancescoBorzi FrancescoBorzi changed the title feat(Doc/Changelog): add changelog for new features docs(Changelog): add changelog for new features Jun 29, 2021
@FrancescoBorzi FrancescoBorzi merged commit 59a3912 into azerothcore:master Jun 29, 2021
@Winfidonarleyan Winfidonarleyan deleted the changelog-1 branch June 29, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yehonal Yehonal Yehonal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changelog TODO
3 participants
@Winfidonarleyan @Yehonal @FrancescoBorzi