feat(Core/MapUpdate): switch from ACE_Method_Request to PCQ #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viste
reviewed
Sep 10, 2020
| @@ -708,11 +708,9 @@ void Map::VisitNearbyCellsOf(WorldObject* obj, TypeContainerVisitor<acore::Objec | |||
|
|
|||
| void Map::Update(const uint32 t_diff, const uint32 s_diff, bool /*thread*/) | |||
| { | |||
| uint32 mapId = GetId(); // pussywizard: for crashlogs | |||
| sLog->outDebug(LOG_FILTER_POOLSYS, "%u", mapId); // pussywizard: for crashlogs | |||
|
|
|||
There was a problem hiding this comment.
sLog->outDebug(LOG_FILTER_POOLSYS, "%u", mapId); // pussywizard: for crashlogs
in end of func
33 tasks
Viste
approved these changes
Sep 12, 2020
|
@Winfidonarleyan please check the commits |
|
@Winfidonarleyan I guess you need to merge lastest master into your PR |
|
cant merge, conflicts, need update for test. |
FrancescoBorzi
added
the
Merge Conflicts
|
@FrancescoBorzi fixed |
FrancescoBorzi
added
Waiting to be tested
and removed
Merge Conflicts
|
Yes, thx. i reassembled and rebuild server. All fork fine. CTRL+C crashes remained. |
Si1ker
approved these changes
Nov 13, 2020
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES PROPOSED:
DelayExecutorISSUES ADDRESSED:
TESTS PERFORMED:
HOW TO TEST THE CHANGES:
LFGsystemTarget branch(es):
How to test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR