Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Core): removed unused ace includes #3874

Merged
merged 3 commits into from Dec 21, 2020
Merged

refactor(Core): removed unused ace includes #3874

merged 3 commits into from Dec 21, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 9, 2020

re #3451

trivial

@github-actions github-actions bot added the CORE label Dec 9, 2020
@ghost ghost changed the title removed unused Guard_T removed unused ace includes Dec 9, 2020
@ghost ghost mentioned this pull request Dec 11, 2020
Closed
33 tasks
@FrancescoBorzi FrancescoBorzi changed the title removed unused ace includes refactor(Core): removed unused ace includes Dec 13, 2020
@FrancescoBorzi
Copy link
Contributor

right, let's merge this

@FrancescoBorzi
Copy link
Contributor

you add a label to merge, when is the actual merge done, is this on a schedule or something?

https://www.azerothcore.org/wiki/merge-process

@FrancescoBorzi
Copy link
Contributor

FrancescoBorzi commented Dec 18, 2020 •
edited
Loading

Seeing PRs like #3863, #3867 being blocked by your "process" kills my motivation to contribute.

just consider them as merged and, if you really need them to be on master (e.g. you plan to do some work that relies on those changes), we can always merge immediately

@ghost
Copy link
Author

ghost commented Dec 19, 2020

if you really need them to be on master

Yes, consider all of my PR "needed in master", it's a motivational/processing-model thing.

@Si1ker Si1ker merged commit d182482 into azerothcore:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrancescoBorzi @Si1ker @abebeos