feat(Core/Authserver): TOTP rewrite #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need #5518 before |
|
What is totp? |
Kitzunu
reviewed
May 3, 2021
WarheadCore/Warhead@421164
Co-authored-by: Kitzunu <[email protected]>
|
Ready to test |
|
Thanks, @Winfidonarleyan ill test this later today. |
|
This looks good. The conversion of existing secrets worked without any problems. removing and setting new 2fa worked great. |
Thanks for tesing, can merge? |
|
@Winfidonarleyan @locus313 what's the status of this? can it be merged? |
|
yeah, think this can be merged |
Si1ker
approved these changes
May 12, 2021
|
#5518 is already merged as WInfi pointed out, let's go with this one. 🐱 |
|
Let's go merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
Issues Addressed:
Tests Performed:
How to Test the Changes:
accountTarget Branch(es):
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.