Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: securely store TOTP secrets [$25 awarded] #5397

Closed
locus313 opened this issue Apr 21, 2021 · 0 comments · Fixed by #5620
Closed

Suggestion: securely store TOTP secrets [$25 awarded] #5397

locus313 opened this issue Apr 21, 2021 · 0 comments · Fixed by #5620

Comments

@locus313
Copy link
Member

locus313 commented Apr 21, 2021 •
edited by AzerothCoreDev
Loading

We probably should look at porting this to more securely store the TOTP secrets:
TrinityCore/TrinityCore@4211645

Currently the TOTP secrets are stored in clear text in the auth database.

The $25 bounty on this issue has been claimed at Bountysource.
Winfidonarleyan added a commit to Winfidonarleyan/azerothcore-wotlk that referenced this issue Apr 28, 2021
@Winfidonarleyan
chore(Core/SharedDefines): move SharedDefines.h to shared lib
7e33b4d 
- Part azerothcore#5397
This was referenced Apr 28, 2021
Merged
Merged
FrancescoBorzi pushed a commit that referenced this issue May 4, 2021
@Winfidonarleyan
chore(Core/SharedDefines): move SharedDefines.h to shared lib (#5518)
545a045 
- Part #5397
@Yehonal Yehonal changed the title Suggestion: securely store TOTP secrets Suggestion: securely store TOTP secrets [$25] May 5, 2021
@Yehonal Yehonal added the Bounty label May 5, 2021
@AzerothCoreDev AzerothCoreDev changed the title Suggestion: securely store TOTP secrets [$25] Suggestion: securely store TOTP secrets [$25 awarded] Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Core/Authserver): TOTP rewrite Winfidonarleyan/azerothcore-wotlk
4 participants
@FrancescoBorzi @Yehonal @locus313 @Azcobu